Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-12 Thread Uros Bizjak
On Thu, Oct 12, 2017 at 9:11 PM, Jakub Jelinek wrote: > On Thu, Oct 12, 2017 at 10:40:22AM +0200, Uros Bizjak wrote: >> > So, if you aren't against it, I can extend the patch to handle the 4 >> > other mask patterns; as for other modes, SImode is what is being handled >> > already, DImode is not a

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-12 Thread Jakub Jelinek
On Thu, Oct 12, 2017 at 10:40:22AM +0200, Uros Bizjak wrote: > > So, if you aren't against it, I can extend the patch to handle the 4 > > other mask patterns; as for other modes, SImode is what is being handled > > already, DImode is not a problem, because the FEs truncate the shift counts > > to i

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-12 Thread Uros Bizjak
On Thu, Oct 12, 2017 at 10:32 AM, Jakub Jelinek wrote: > On Thu, Oct 12, 2017 at 08:32:32AM +0200, Uros Bizjak wrote: >> On Wed, Oct 11, 2017 at 10:59 PM, Jakub Jelinek wrote: >> > As can be seen on the testcase below, the *3_mask >> > insn/splitter is able to optimize only the case when the and

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-12 Thread Jakub Jelinek
On Thu, Oct 12, 2017 at 08:32:32AM +0200, Uros Bizjak wrote: > On Wed, Oct 11, 2017 at 10:59 PM, Jakub Jelinek wrote: > > As can be seen on the testcase below, the *3_mask > > insn/splitter is able to optimize only the case when the and is > > performed in SImode and then the result subreged into

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-11 Thread Uros Bizjak
On Thu, Oct 12, 2017 at 8:39 AM, Uros Bizjak wrote: > On Thu, Oct 12, 2017 at 8:32 AM, Uros Bizjak wrote: >> On Wed, Oct 11, 2017 at 10:59 PM, Jakub Jelinek wrote: >>> Hi! >>> >>> As can be seen on the testcase below, the *3_mask >>> insn/splitter is able to optimize only the case when the and i

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-11 Thread Uros Bizjak
On Thu, Oct 12, 2017 at 8:32 AM, Uros Bizjak wrote: > On Wed, Oct 11, 2017 at 10:59 PM, Jakub Jelinek wrote: >> Hi! >> >> As can be seen on the testcase below, the *3_mask >> insn/splitter is able to optimize only the case when the and is >> performed in SImode and then the result subreged into Q

Re: [PATCH] Improve x86 and + rotate (PR target/82498)

2017-10-11 Thread Uros Bizjak
On Wed, Oct 11, 2017 at 10:59 PM, Jakub Jelinek wrote: > Hi! > > As can be seen on the testcase below, the *3_mask > insn/splitter is able to optimize only the case when the and is > performed in SImode and then the result subreged into QImode, > while if the computation is already in QImode, we d