Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-09 Thread Andrew MacLeod via Gcc-patches
On 6/9/21 7:32 AM, Richard Biener wrote: On Tue, Jun 8, 2021 at 4:31 PM Andrew MacLeod wrote: an iteration causes a relation to become "better" it should be updated. do a very simplistic thing when trying to simplify downstream conditions based on earlier ones, abusing their known-expressions

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-09 Thread Martin Sebor via Gcc-patches
On 6/9/21 12:50 PM, Aldy Hernandez wrote: On 6/9/21 7:10 PM, Martin Sebor wrote: On 6/7/21 12:29 PM, Aldy Hernandez via Gcc-patches wrote: Mostly just a question of the type choices in the implementation of the ssa_equiv_stack class: m_stack is an auto_vec while m_replacements is a plain

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-09 Thread Aldy Hernandez via Gcc-patches
On 6/9/21 7:10 PM, Martin Sebor wrote: On 6/7/21 12:29 PM, Aldy Hernandez via Gcc-patches wrote: Mostly just a question of the type choices in the implementation of the ssa_equiv_stack class: m_stack is an auto_vec while m_replacements is a plain array.  I'd expect both to be the same (au

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-09 Thread Martin Sebor via Gcc-patches
On 6/7/21 12:29 PM, Aldy Hernandez via Gcc-patches wrote: On 6/7/21 3:30 PM, Richard Biener wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which rang

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-09 Thread Richard Biener via Gcc-patches
On Tue, Jun 8, 2021 at 4:31 PM Andrew MacLeod wrote: > > On 6/8/21 3:26 AM, Richard Biener wrote: > > On Mon, Jun 7, 2021 at 9:20 PM Andrew MacLeod wrote: > >> > >> I don't think this is actually doing the propagation though... It tracks > >> that a_2 currently points to &foo.. and returns that t

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-08 Thread Andrew MacLeod via Gcc-patches
On 6/8/21 3:26 AM, Richard Biener wrote: On Mon, Jun 7, 2021 at 9:20 PM Andrew MacLeod wrote: I don't think this is actually doing the propagation though... It tracks that a_2 currently points to &foo.. and returns that to either simplifier or folder thru value_of_expr(). Presumably it is up

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-08 Thread Andrew MacLeod via Gcc-patches
On 6/8/21 2:26 AM, Aldy Hernandez wrote: On 6/7/21 9:20 PM, Andrew MacLeod wrote: On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_o

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-08 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 9:20 PM Andrew MacLeod wrote: > > On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: > > On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches > > wrote: > >> The substitute_and_fold_engine which evrp uses is expecting symbolics > >> from value_of_expr / valu

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On 6/7/21 9:20 PM, Andrew MacLeod wrote: On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which range

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which ranger does not provide. In some cases, these prov

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On 6/7/21 3:30 PM, Richard Biener wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which ranger does not provide. In some cases, these provide important

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: > > The substitute_and_fold_engine which evrp uses is expecting symbolics > from value_of_expr / value_on_edge / etc, which ranger does not provide. > In some cases, these provide important folding cues, as in the case of > alia

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
Sorry, meant to append... "OK for trunk?" :) On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez wrote: > > The substitute_and_fold_engine which evrp uses is expecting symbolics > from value_of_expr / value_on_edge / etc, which ranger does not provide. > In some cases, these provide important folding