Re: [PATCH] Fix overflow handling in std::align

2020-09-22 Thread Jonathan Wakely via Gcc-patches
On 21/09/20 15:50 +0100, Jonathan Wakely wrote: On 21/09/20 10:42 -0400, Glen Fernandes via Libstdc++ wrote: On Mon, Sep 14, 2020 at 5:44 PM Thomas Rodgers wrote: On Sep 14, 2020, at 7:30 AM, Ville Voutilainen wrote: On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: Sounds like a good id

Re: [PATCH] Fix overflow handling in std::align

2020-09-21 Thread Jonathan Wakely via Gcc-patches
On 21/09/20 10:42 -0400, Glen Fernandes via Libstdc++ wrote: On Mon, Sep 14, 2020 at 5:44 PM Thomas Rodgers wrote: > On Sep 14, 2020, at 7:30 AM, Ville Voutilainen wrote: > > On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: >> Sounds like a good idea. Updated patch attached. > > Looks good

Re: [PATCH] Fix overflow handling in std::align

2020-09-21 Thread Glen Fernandes via Gcc-patches
On Mon, Sep 14, 2020 at 5:44 PM Thomas Rodgers wrote: > > On Sep 14, 2020, at 7:30 AM, Ville Voutilainen wrote: > > > > On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: > >> Sounds like a good idea. Updated patch attached. > > > > Looks good to me. > > Agree. Rebased patch on latest changes

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Thomas Rodgers
> On Sep 14, 2020, at 7:30 AM, Ville Voutilainen via Libstdc++ > wrote: > > On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: >> >> On Mon, Sep 14, 2020 at 5:52 AM Ville Voutilainen wrote: >>> On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen >>> wrote: On Mon, 14 Sep 2020 at 09:18, Gl

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Ville Voutilainen via Gcc-patches
On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: > > On Mon, Sep 14, 2020 at 5:52 AM Ville Voutilainen wrote: > > On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen > > wrote: > > > On Mon, 14 Sep 2020 at 09:18, Glen Fernandes > > wrote: > > > > Edit; Correct patch this time. > > > > > > > > Fix

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Glen Fernandes via Gcc-patches
On Mon, Sep 14, 2020 at 5:52 AM Ville Voutilainen wrote: > On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen > wrote: > > On Mon, 14 Sep 2020 at 09:18, Glen Fernandes > wrote: > > > Edit; Correct patch this time. > > > > > > Fix overflow handling in align > > > > Should the test verify that space is

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Ville Voutilainen via Gcc-patches
On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen wrote: > > On Mon, 14 Sep 2020 at 09:18, Glen Fernandes via Libstdc++ > wrote: > > > > Edit; Correct patch this time. > > > > Fix overflow handling in align > > Should the test verify that space is unmodified when nullptr is returned? ..and same fo

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Ville Voutilainen via Gcc-patches
On Mon, 14 Sep 2020 at 09:18, Glen Fernandes via Libstdc++ wrote: > > Edit; Correct patch this time. > > Fix overflow handling in align Should the test verify that space is unmodified when nullptr is returned?