Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests

2015-06-02 Thread Dominik Vogt
On Mon, Jun 01, 2015 at 12:29:31PM +0200, Jakub Jelinek wrote: > On Mon, Jun 01, 2015 at 11:20:29AM +0100, Dominik Vogt wrote: > > There are many more > > test cases that forget the "inline" and filter the warning with > > "-Wno-attributes". I'll post an add-on patch later after testing > > it. >

Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests

2015-06-01 Thread Andreas Krebbel
On 06/01/2015 10:39 AM, Jakub Jelinek wrote: > Hi! > > always_inline attribute is meaningful only for functions declared > inline, and the compiler even warns about this, so it is unclear > to me why the tests are attempting to use that. > > 2015-06-01 Jakub Jelinek > > * gcc.target/s39

Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests

2015-06-01 Thread Jakub Jelinek
On Mon, Jun 01, 2015 at 11:20:29AM +0100, Dominik Vogt wrote: > On Mon, Jun 01, 2015 at 10:39:34AM +0200, Jakub Jelinek wrote: > > always_inline attribute is meaningful only for functions declared > > inline, and the compiler even warns about this, so it is unclear > > to me why the tests are attem

Re: [PATCH] Fix misuse of always_inline attribute in 3 hotpatch tests

2015-06-01 Thread Dominik Vogt
On Mon, Jun 01, 2015 at 10:39:34AM +0200, Jakub Jelinek wrote: > always_inline attribute is meaningful only for functions declared > inline, and the compiler even warns about this, so it is unclear > to me why the tests are attempting to use that. Since Gcc emits just a cryptic warning and not an