Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-12-09 Thread Kevin Buettner
On Fri, 16 Nov 2018 22:10:00 +0100 Jakub Jelinek wrote: > Kevin, did you have some gdb testcases you were trying for the r253335 > change? Can you try those with added another e.g. parallel around it (say > #pragma omp parallel if (0) or num_threads (1), so that it doesn't spawn too > many child

Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-11-19 Thread Richard Biener
On Sat, 17 Nov 2018, Jakub Jelinek wrote: > On Sat, Nov 17, 2018 at 05:51:05PM +0100, Richard Biener wrote: > > On November 17, 2018 4:14:58 PM GMT+01:00, Jakub Jelinek > > wrote: > > >On Sat, Nov 17, 2018 at 08:31:32AM +0100, Richard Biener wrote: > > >> On November 16, 2018 10:10:00 PM GMT+01:

Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-11-17 Thread Jakub Jelinek
On Sat, Nov 17, 2018 at 05:51:05PM +0100, Richard Biener wrote: > On November 17, 2018 4:14:58 PM GMT+01:00, Jakub Jelinek > wrote: > >On Sat, Nov 17, 2018 at 08:31:32AM +0100, Richard Biener wrote: > >> On November 16, 2018 10:10:00 PM GMT+01:00, Jakub Jelinek > >> wrote: Can you add a comment

Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-11-17 Thread Richard Biener
On November 17, 2018 4:14:58 PM GMT+01:00, Jakub Jelinek wrote: >On Sat, Nov 17, 2018 at 08:31:32AM +0100, Richard Biener wrote: >> On November 16, 2018 10:10:00 PM GMT+01:00, Jakub Jelinek >> wrote: Can you add a comment why doing it >differently >> for this case is necessary or do it the same

Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-11-17 Thread Jakub Jelinek
On Sat, Nov 17, 2018 at 08:31:32AM +0100, Richard Biener wrote: > On November 16, 2018 10:10:00 PM GMT+01:00, Jakub Jelinek > wrote: Can you add a comment why doing it differently > for this case is necessary or do it the same way in all cases? Do you mean in omp-expand.c or dwarf2out.c? I belie

Re: [PATCH] Fix debuginfo in -fopenmp code (PR debug/87039)

2018-11-16 Thread Richard Biener
On November 16, 2018 10:10:00 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As mentioned in the PR, the PR78363 changes were done too early, as >some of >the BLOCKs are moved to the outlined function, it is undesirable to >generate >DW_TAG_lexical_block DIEs for them in a different function from whi