Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-06-01 Thread Richard Biener
On Sun, Jun 1, 2025 at 12:54 PM Eric Botcazou wrote: > > > If one wants to look up something in symbol table during late optimization > > one is supposed to check that ::get does not return NULL and be conservative > > otheriwse. So your change for PR120156 was OK with me, but I did not > > expli

Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-06-01 Thread Eric Botcazou
> If one wants to look up something in symbol table during late optimization > one is supposed to check that ::get does not return NULL and be conservative > otheriwse. So your change for PR120156 was OK with me, but I did not > explicitly write (sorty for that). Similarly for vectorizer I would s

Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-05-30 Thread Jan Hubicka
> On Fri, May 30, 2025 at 11:30 AM Jan Hubicka wrote: > > > > Hi, > > > > > > > > Hi, > > > > > > > > the attached Ada testcase compiled with -O2 -gnatn makes the compiler > > > > crash in > > > > vect_can_force_dr_alignment_p during SLP vectorization: > > > > > > > > if (decl_in_symtab_p (decl

Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-05-30 Thread Jan Hubicka
Hi, > > > > Hi, > > > > the attached Ada testcase compiled with -O2 -gnatn makes the compiler crash > > in > > vect_can_force_dr_alignment_p during SLP vectorization: > > > > if (decl_in_symtab_p (decl) > > && !symtab_node::get (decl)->can_increase_alignment_p ()) > > return false; > >

Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-05-30 Thread Richard Biener
On Fri, May 30, 2025 at 11:30 AM Jan Hubicka wrote: > > Hi, > > > > > > Hi, > > > > > > the attached Ada testcase compiled with -O2 -gnatn makes the compiler > > > crash in > > > vect_can_force_dr_alignment_p during SLP vectorization: > > > > > > if (decl_in_symtab_p (decl) > > > && !symt

Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-05-29 Thread Richard Biener
On Thu, May 29, 2025 at 11:38 AM Eric Botcazou wrote: > > Hi, > > the attached Ada testcase compiled with -O2 -gnatn makes the compiler crash in > vect_can_force_dr_alignment_p during SLP vectorization: > > if (decl_in_symtab_p (decl) > && !symtab_node::get (decl)->can_increase_alignment_p