Re: [PATCH] Fix check for whether a function is a variadic function

2015-04-20 Thread Jason Merrill
On 04/20/2015 09:02 AM, Patrick Palka wrote: But never mind, I'm getting hundreds of failures from C tests that define main without a parameter list e.g. "int main () { ... }". This is an issue not worth fixing.. Yep, that's what I was wondering. I think it makes sense to fix this testcase i

Re: [PATCH] Fix check for whether a function is a variadic function

2015-04-20 Thread Patrick Palka
On Sun, Apr 19, 2015 at 11:17 PM, Jason Merrill wrote: > On 04/19/2015 07:45 PM, Patrick Palka wrote: >> >> stdarg_p() apparently returns false for a variadic function that has no >> concrete parameters, e.g. "void foo (...);". This patch fixes this >> issue by removing the predicate's seemingly

Re: [PATCH] Fix check for whether a function is a variadic function

2015-04-19 Thread Jason Merrill
On 04/19/2015 07:45 PM, Patrick Palka wrote: stdarg_p() apparently returns false for a variadic function that has no concrete parameters, e.g. "void foo (...);". This patch fixes this issue by removing the predicate's seemingly bogus "n != NULL_TREE" test. What does this do with K&R non-protot