Re: [PATCH] Fix a recent warning in reorg.c

2016-04-27 Thread Mike Stump
> On Apr 26, 2016, at 5:56 PM, Trevor Saunders wrote: > So pre ISO C++ gave the second decl the same scope as the first one? > that's... exciting ;) So, all the code in the world that is meant to be ported up the an ANSI standard for C++ has already been so ported, we could remove all notion th

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Trevor Saunders
On Tue, Apr 26, 2016 at 09:03:03AM -0600, Jeff Law wrote: > On 04/26/2016 07:08 AM, Jakub Jelinek wrote: > >Hi! > > > >I've noticed a warning during bootstrap: > >../../gcc/reorg.c: In function ‘void try_merge_delay_insns(rtx_insn*, > >rtx_insn*)’: > >../../gcc/reorg.c:1431:12: warning: name looku

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Bernd Schmidt
On 04/26/2016 05:41 PM, Jakub Jelinek wrote: On Tue, Apr 26, 2016 at 03:13:32PM +0200, Bernd Schmidt wrote: On 04/26/2016 03:08 PM, Jakub Jelinek wrote: ^ ../../gcc/reorg.c:1413:25: warning: matches this ‘i’ under old rules for (unsigned int i = len - 1; i < len; i--)

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Jakub Jelinek
On Tue, Apr 26, 2016 at 03:13:32PM +0200, Bernd Schmidt wrote: > On 04/26/2016 03:08 PM, Jakub Jelinek wrote: > >^ > >../../gcc/reorg.c:1413:25: warning: matches this ‘i’ under old rules > >for (unsigned int i = len - 1; i < len; i--) > > ^ > > Oh, and al

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Jeff Law
On 04/26/2016 07:08 AM, Jakub Jelinek wrote: Hi! I've noticed a warning during bootstrap: ../../gcc/reorg.c: In function ‘void try_merge_delay_insns(rtx_insn*, rtx_insn*)’: ../../gcc/reorg.c:1431:12: warning: name lookup of ‘i’ changed for (i = 0; i < XVECLEN (PATTERN (insn), 0); i++)

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Bernd Schmidt
On 04/26/2016 03:08 PM, Jakub Jelinek wrote: ^ ../../gcc/reorg.c:1413:25: warning: matches this ‘i’ under old rules for (unsigned int i = len - 1; i < len; i--) ^ Oh, and also - I flagged this while reviewing other parts of Trevor's changes, this pat

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Bernd Schmidt
On 04/26/2016 03:08 PM, Jakub Jelinek wrote: It is not fatal, but still ugly. The problem is that the function has int i; ... for (i = 0; ...) ... for (unsigned int i = ... ) ... for (i = 0; ...) This patch just declares the var in the only affected loop, so that the warning is not e