Re: [PATCH] Fix PR61221

2014-05-20 Thread Jeff Law
On 05/20/14 12:13, Richard Biener wrote: I think it's still important for things like keeping SSA names densely allocated and for reuse on SSA rewrite of virtual operands for example. So I'm thinking of an explicit stop-/restart-reuse interface. Fair enough. WRT dense allocation, we could proba

Re: [PATCH] Fix PR61221

2014-05-20 Thread Richard Biener
On May 20, 2014 6:47:44 PM CEST, Jeff Law wrote: >On 05/20/14 02:06, Richard Biener wrote: >> >> We're still going to have problems if SSA names are re-used >> (as even released SSA names have to remain valid lattice >> entries after this). But currently nothing will create new >> SSA names (fing

Re: [PATCH] Fix PR61221

2014-05-20 Thread Jeff Law
On 05/20/14 02:06, Richard Biener wrote: We're still going to have problems if SSA names are re-used (as even released SSA names have to remain valid lattice entries after this). But currently nothing will create new SSA names (fingers crossing) during eliminate. A followup patch of mine will

Re: [PATCH] Fix PR61221

2014-05-20 Thread Richard Biener
On Mon, 19 May 2014, Richard Biener wrote: > On May 19, 2014 6:57:52 PM CEST, Jeff Law wrote: > >On 05/19/14 06:54, Richard Biener wrote: > >> > >> In this PR we run into the issue that releasing SSA names from > >> FRE/PRE elimination corrupts the VN lattice and thus the VN lookup > >> we perfor

Re: [PATCH] Fix PR61221

2014-05-19 Thread Richard Biener
On May 19, 2014 6:57:52 PM CEST, Jeff Law wrote: >On 05/19/14 06:54, Richard Biener wrote: >> >> In this PR we run into the issue that releasing SSA names from >> FRE/PRE elimination corrupts the VN lattice and thus the VN lookup >> we perform for removing redudnant stores ICEs. The patch works >

Re: [PATCH] Fix PR61221

2014-05-19 Thread Jeff Law
On 05/19/14 06:54, Richard Biener wrote: In this PR we run into the issue that releasing SSA names from FRE/PRE elimination corrupts the VN lattice and thus the VN lookup we perform for removing redudnant stores ICEs. The patch works around the particular case by making unreachable code detecti