Re: [PATCH] Fix PR55152

2016-10-16 Thread Andrew Pinski
On Tue, Oct 4, 2016 at 2:50 AM, Richard Biener wrote: > On Tue, 4 Oct 2016, Marc Glisse wrote: > >> On Tue, 4 Oct 2016, Richard Biener wrote: >> >> > Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). >> >> I thought this might fix PR 62055, but at least on x86_64, we genera

Re: [PATCH] Fix PR55152

2016-10-05 Thread Richard Biener
On Wed, 5 Oct 2016, Richard Biener wrote: > On Tue, 4 Oct 2016, Joseph Myers wrote: > > > On Tue, 4 Oct 2016, Richard Biener wrote: > > > > > On Tue, 4 Oct 2016, Joseph Myers wrote: > > > > > > > On Tue, 4 Oct 2016, Richard Biener wrote: > > > > > > > > > Possibly. Though then for FP we also

Re: [PATCH] Fix PR55152

2016-10-05 Thread Richard Biener
On Tue, 4 Oct 2016, Joseph Myers wrote: > On Tue, 4 Oct 2016, Richard Biener wrote: > > > On Tue, 4 Oct 2016, Joseph Myers wrote: > > > > > On Tue, 4 Oct 2016, Richard Biener wrote: > > > > > > > Possibly. Though then for FP we also want - abs (a) -> copysign (a, > > > > -1). > > > > > > For

Re: [PATCH] Fix PR55152

2016-10-04 Thread Joseph Myers
On Tue, 4 Oct 2016, Richard Biener wrote: > On Tue, 4 Oct 2016, Joseph Myers wrote: > > > On Tue, 4 Oct 2016, Richard Biener wrote: > > > > > Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). > > > > For architectures such as powerpc that have a negated-abs instruction,

Re: [PATCH] Fix PR55152

2016-10-04 Thread Richard Biener
On Tue, 4 Oct 2016, Joseph Myers wrote: > On Tue, 4 Oct 2016, Richard Biener wrote: > > > Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). > > For architectures such as powerpc that have a negated-abs instruction, > does it get properly generated from the copysign code?

Re: [PATCH] Fix PR55152

2016-10-04 Thread Joseph Myers
On Tue, 4 Oct 2016, Richard Biener wrote: > Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). For architectures such as powerpc that have a negated-abs instruction, does it get properly generated from the copysign code? (The relevant pattern in rs6000.md uses (neg (abs)

Re: [PATCH] Fix PR55152

2016-10-04 Thread Richard Biener
On Tue, 4 Oct 2016, Marc Glisse wrote: > On Tue, 4 Oct 2016, Richard Biener wrote: > > > Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). > > I thought this might fix PR 62055, but at least on x86_64, we generate much > worse code for copysign(,-1) than for -abs :-( I w

Re: [PATCH] Fix PR55152

2016-10-04 Thread Marc Glisse
On Tue, 4 Oct 2016, Richard Biener wrote: Possibly. Though then for FP we also want - abs (a) -> copysign (a, -1). I thought this might fix PR 62055, but at least on x86_64, we generate much worse code for copysign(,-1) than for -abs :-( -- Marc Glisse

Re: [PATCH] Fix PR55152

2016-10-04 Thread Richard Biener
On Fri, 30 Sep 2016, Andrew Pinski wrote: > On Thu, Sep 29, 2016 at 8:23 PM, Richard Biener wrote: > > On Thu, 29 Sep 2016, Richard Biener wrote: > > > >> On Wed, 28 Sep 2016, Joseph Myers wrote: > >> > >> > On Wed, 28 Sep 2016, Richard Biener wrote: > >> > > >> > > Index: gcc/testsuite/gcc.dg/pr

Re: [PATCH] Fix PR55152

2016-09-29 Thread Andrew Pinski
On Thu, Sep 29, 2016 at 8:23 PM, Richard Biener wrote: > On Thu, 29 Sep 2016, Richard Biener wrote: > >> On Wed, 28 Sep 2016, Joseph Myers wrote: >> >> > On Wed, 28 Sep 2016, Richard Biener wrote: >> > >> > > Index: gcc/testsuite/gcc.dg/pr55152.c >> > >

Re: [PATCH] Fix PR55152

2016-09-29 Thread Richard Biener
On Thu, 29 Sep 2016, Richard Biener wrote: > On Wed, 28 Sep 2016, Joseph Myers wrote: > > > On Wed, 28 Sep 2016, Richard Biener wrote: > > > > > Index: gcc/testsuite/gcc.dg/pr55152.c > > > === > > > --- gcc/testsuite/gcc.dg/pr55152.

Re: [PATCH] Fix PR55152

2016-09-29 Thread Richard Biener
On Wed, 28 Sep 2016, Joseph Myers wrote: > On Wed, 28 Sep 2016, Richard Biener wrote: > > > Index: gcc/testsuite/gcc.dg/pr55152.c > > === > > --- gcc/testsuite/gcc.dg/pr55152.c (revision 0) > > +++ gcc/testsuite/gcc.dg/pr55152.c (w

Re: [PATCH] Fix PR55152

2016-09-28 Thread Joseph Myers
On Wed, 28 Sep 2016, Richard Biener wrote: > Index: gcc/testsuite/gcc.dg/pr55152.c > === > --- gcc/testsuite/gcc.dg/pr55152.c(revision 0) > +++ gcc/testsuite/gcc.dg/pr55152.c(working copy) > @@ -0,0 +1,13 @@ > +/* { dg-do comp