Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-17 Thread William J. Schmidt
On Tue, 2011-05-17 at 11:03 +0200, Richard Guenther wrote: > On Mon, May 16, 2011 at 7:30 PM, William J. Schmidt > wrote: > > Richi, thank you for the detailed review! > > > > I'll plan to move the power-series expansion into the existing IL walk > > during pass_cse_sincos. As part of this, I'll

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-17 Thread Richard Guenther
On Mon, May 16, 2011 at 7:30 PM, William J. Schmidt wrote: > Richi, thank you for the detailed review! > > I'll plan to move the power-series expansion into the existing IL walk > during pass_cse_sincos.  As part of this, I'll move > tree_expand_builtin_powi and its subfunctions from builtins.c in

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-16 Thread William J. Schmidt
Richi, thank you for the detailed review! I'll plan to move the power-series expansion into the existing IL walk during pass_cse_sincos. As part of this, I'll move tree_expand_builtin_powi and its subfunctions from builtins.c into tree-ssa-math-opts.c. I'll submit this as a separate patch. I wi

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-16 Thread Richard Guenther
On Fri, May 13, 2011 at 6:00 PM, Nathan Froyd wrote: > On 05/13/2011 11:26 AM, Richard Guenther wrote: >> On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd >> wrote: >>> On 05/13/2011 10:52 AM, William J. Schmidt wrote: This patch addresses PR46728, which notes that pow and powi need to be

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread William J. Schmidt
On Fri, 2011-05-13 at 10:52 -0500, William J. Schmidt wrote: > On Fri, 2011-05-13 at 17:26 +0200, Richard Guenther wrote: -- snip -- > > > > The position of the pass is odd - why did you place it there? I would > > have placed it alongside pass_cse_sincos and pass_optimize_bswap. > > That was

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Nathan Froyd
On 05/13/2011 11:26 AM, Richard Guenther wrote: > On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd > wrote: >> On 05/13/2011 10:52 AM, William J. Schmidt wrote: >>> This patch addresses PR46728, which notes that pow and powi need to be >>> lowered in tree phases to restore lost FMA opportunities and

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread William J. Schmidt
On Fri, 2011-05-13 at 17:26 +0200, Richard Guenther wrote: > On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd > wrote: > > On 05/13/2011 10:52 AM, William J. Schmidt wrote: > >> This patch addresses PR46728, which notes that pow and powi need to be > >> lowered in tree phases to restore lost FMA op

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd wrote: > On 05/13/2011 10:52 AM, William J. Schmidt wrote: >> This patch addresses PR46728, which notes that pow and powi need to be >> lowered in tree phases to restore lost FMA opportunities and expose >> vectorization opportunities. >> >> +struct gi

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Nathan Froyd
On 05/13/2011 10:52 AM, William J. Schmidt wrote: > This patch addresses PR46728, which notes that pow and powi need to be > lowered in tree phases to restore lost FMA opportunities and expose > vectorization opportunities. > > +struct gimple_opt_pass pass_lower_pow = > +{ > + { > + GIMPLE_PASS, >