Re: [PATCH] Disable unroll loop that has header count less than iteration count.

2014-05-23 Thread Jan Hubicka
> > > > if (expected_loop_iterations_reliable_p (loop)) > > niters = expected_loop_iterations (loop); > > But why not simply never return bogus values from expected-loop-iterations? Hmm, actually we do have: /* If we have a measured profile, use it to estimate the number of iterations.

Re: [PATCH] Disable unroll loop that has header count less than iteration count.

2014-05-23 Thread Richard Biener
On May 23, 2014 7:26:04 PM CEST, Jan Hubicka wrote: >> On Thu, May 22, 2014 at 11:36 PM, Dehao Chen >wrote: >> > If a loop's header count is less than iteration count, the >iteration >> > estimation is apparently incorrect for this loop. Thus disable >> > unrolling of such loops. >> > >> > Testin

Re: [PATCH] Disable unroll loop that has header count less than iteration count.

2014-05-23 Thread Jan Hubicka
> On Thu, May 22, 2014 at 11:36 PM, Dehao Chen wrote: > > If a loop's header count is less than iteration count, the iteration > > estimation is apparently incorrect for this loop. Thus disable > > unrolling of such loops. > > > > Testing on going. OK for trunk if test pass? > > No. Why don't yo

Re: [PATCH] Disable unroll loop that has header count less than iteration count.

2014-05-23 Thread Richard Biener
On Thu, May 22, 2014 at 11:36 PM, Dehao Chen wrote: > If a loop's header count is less than iteration count, the iteration > estimation is apparently incorrect for this loop. Thus disable > unrolling of such loops. > > Testing on going. OK for trunk if test pass? No. Why don't you instead plug t