Re: [PATCH] Better .debug_aranges fix (PR debug/48253, take 3)

2011-03-28 Thread Jason Merrill
On 03/28/2011 10:34 AM, Jakub Jelinek wrote: So perhaps if (fde->dw_fde_second_begin&& fde->dw_fde_switch_cfi == NULL) { /* If the first partition contained no CFI adjustments, the CIE opcodes apply to the whole first partition. */ *list_tail = new_loc_list (build

Re: [PATCH] Better .debug_aranges fix (PR debug/48253, take 3)

2011-03-28 Thread Jakub Jelinek
On Mon, Mar 28, 2011 at 10:23:08AM -0400, Jason Merrill wrote: > On 03/25/2011 01:01 PM, Jakub Jelinek wrote: > >+if (node == loc_list->last_before_switch > >+&& (node != loc_list->first || loc_list->first->next) > >+&& current_function_decl) > > Let's store this te

Re: [PATCH] Better .debug_aranges fix (PR debug/48253, take 3)

2011-03-28 Thread Jason Merrill
On 03/25/2011 01:01 PM, Jakub Jelinek wrote: + if (node == loc_list->last_before_switch + && (node != loc_list->first || loc_list->first->next) + && current_function_decl) Let's store this test in a local variable rather than repeat it a few lines down.