Re: [PATCH] Asan constructor init order checking

2013-11-22 Thread Jakub Jelinek
On Fri, Nov 22, 2013 at 09:46:47PM +0400, Alexander Potapenko wrote: > Side note: init order checking isn't supposed to work on Darwin, at least > for now. I'll let Darwin maintainers/users if any to worry about it, that said, does it have any compiler side effects (like, that dynamic_init shouldn

Re: [PATCH] Asan constructor init order checking

2013-11-22 Thread Dodji Seketeli
Jakub Jelinek writes: > On Fri, Nov 22, 2013 at 04:38:58PM +0100, Dodji Seketeli wrote: >> Jakub Jelinek writes: >> >> > --- gcc/cgraph.h.jj2013-11-13 18:32:52.0 +0100 >> > +++ gcc/cgraph.h 2013-11-15 12:05:25.950985500 +0100 >> > @@ -520,6 +520,11 @@ class GTY((tag ("SYMTAB_V

Re: [PATCH] Asan constructor init order checking

2013-11-22 Thread Jakub Jelinek
On Fri, Nov 22, 2013 at 04:38:58PM +0100, Dodji Seketeli wrote: > Jakub Jelinek writes: > > > --- gcc/cgraph.h.jj 2013-11-13 18:32:52.0 +0100 > > +++ gcc/cgraph.h2013-11-15 12:05:25.950985500 +0100 > > @@ -520,6 +520,11 @@ class GTY((tag ("SYMTAB_VARIABLE"))) var > > public: > >/

Re: [PATCH] Asan constructor init order checking

2013-11-22 Thread Dodji Seketeli
Dodji Seketeli writes: > Also, do we have some tests for this? I am not sure how I'd write > multi-tu dejagnu tests for this myself though ;-) Woops, I have just seen the sub-thread about the tests with Konstantin, you and Alexey. Sorry. Cheers. -- Dodji

Re: [PATCH] Asan constructor init order checking

2013-11-22 Thread Dodji Seketeli
Hello, Jakub Jelinek writes: > --- gcc/cgraph.h.jj 2013-11-13 18:32:52.0 +0100 > +++ gcc/cgraph.h 2013-11-15 12:05:25.950985500 +0100 > @@ -520,6 +520,11 @@ class GTY((tag ("SYMTAB_VARIABLE"))) var > public: >/* Set when variable is scheduled to be assembled. */ >unsigne

Re: [PATCH] Asan constructor init order checking

2013-11-15 Thread Konstantin Serebryany
On Fri, Nov 15, 2013 at 10:46 PM, Jakub Jelinek wrote: > On Fri, Nov 15, 2013 at 10:34:28PM +0400, Konstantin Serebryany wrote: >> +samsonov, who wrote the clang part >> >> Do you plan to add tests? > > OT, what is the -fsanitize=address,use-after-scope doing? Tried that > and it didn't seem to d

Re: [PATCH] Asan constructor init order checking

2013-11-15 Thread Konstantin Serebryany
On Fri, Nov 15, 2013 at 10:40 PM, Jakub Jelinek wrote: > On Fri, Nov 15, 2013 at 10:34:28PM +0400, Konstantin Serebryany wrote: >> +samsonov, who wrote the clang part >> >> Do you plan to add tests? > > Eventually yes, but likely only in stage3, there is only limited time > left during stage1 and

Re: [PATCH] Asan constructor init order checking

2013-11-15 Thread Jakub Jelinek
On Fri, Nov 15, 2013 at 10:34:28PM +0400, Konstantin Serebryany wrote: > +samsonov, who wrote the clang part > > Do you plan to add tests? OT, what is the -fsanitize=address,use-after-scope doing? Tried that and it didn't seem to do anything at all, besides adding some extra start/end scope mark

Re: [PATCH] Asan constructor init order checking

2013-11-15 Thread Jakub Jelinek
On Fri, Nov 15, 2013 at 10:34:28PM +0400, Konstantin Serebryany wrote: > +samsonov, who wrote the clang part > > Do you plan to add tests? Eventually yes, but likely only in stage3, there is only limited time left during stage1 and I need to still work on OpenMP elementals next week. > We have f

Re: [PATCH] Asan constructor init order checking

2013-11-15 Thread Konstantin Serebryany
+samsonov, who wrote the clang part Do you plan to add tests? We have four lit-style tests for this (Alexey, that's all, right?): init-order-atexit.cc init-order-dlopen.cc init-order-pthread-create.cc Linux/initialization-bug-any-order.cc I think we need at least the basic one in gcc (Linux/initi