RE: [PATCH] Add Optimization for various IPA parameters.

2020-01-14 Thread Tamar Christina
Wednesday, January 8, 2020 4:14 PM > >> To: Martin Liška ; gcc-patches@gcc.gnu.org > >> Cc: hubi...@ucw.cz; Richard Biener > >> Subject: Re: [PATCH] Add Optimization for various IPA parameters. > >> > >> Hi, > >> > >> On Fri, Jan 03 202

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-13 Thread luoxhu
er Subject: Re: [PATCH] Add Optimization for various IPA parameters. Hi, On Fri, Jan 03 2020, Martin Liška wrote: Hi. This is similar transformation for IPA passes. This time, one needs to use opt_for_fn in order to get the right parameter values. @Martin, Honza: There are last few remaining p

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-13 Thread Martin Jambor
Hi, On Mon, Jan 13 2020, Martin Liška wrote: > On 1/11/20 1:20 PM, Tamar Christina wrote: >> It seems the parameters no longer do anything. i.e. -flto --param >> ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=80 doesn't have any >> effect anymore. > > Hi. > > You are right, the param '--para

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-13 Thread Martin Liška
On 1/11/20 1:20 PM, Tamar Christina wrote: It seems the parameters no longer do anything. i.e. -flto --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=80 doesn't have any effect anymore. Hi. You are right, the param '--param ipa-cp-unit-growth' is really unused. It's cause by Martin

RE: [PATCH] Add Optimization for various IPA parameters.

2020-01-11 Thread Tamar Christina
ymore. Thanks, Tamar > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org > On Behalf Of Martin Jambor > Sent: Wednesday, January 8, 2020 4:14 PM > To: Martin Liška ; gcc-patches@gcc.gnu.org > Cc: hubi...@ucw.cz; Richard Biener > Subject: Re: [PATCH] Add Op

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-09 Thread Martin Liška
On 1/9/20 12:06 PM, Jan Hubicka wrote: 2020-01-03 Martin Liska * auto-profile.c (auto_profile): Use opt_for_fn for a parameter. * ipa-cp.c (ipcp_lattice::add_value): Likewise. (propagate_vals_across_arith_jfunc): Likewise. (hint_time_bonus): Likewise.

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-09 Thread Martin Liška
On 1/8/20 5:14 PM, Martin Jambor wrote: + int unit_growth = opt_for_fn (node->decl, param_ipcp_unit_growth); Sorry, but I renamed you the param to param_ipa_cp_unit_growth. Which is a name that matches name conventions of other IPA CP related parameters. Please rebase the patch. Thanks, Marti

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-09 Thread Jan Hubicka
> 2020-01-03 Martin Liska > > * auto-profile.c (auto_profile): Use opt_for_fn > for a parameter. > * ipa-cp.c (ipcp_lattice::add_value): Likewise. > (propagate_vals_across_arith_jfunc): Likewise. > (hint_time_bonus): Likewise. > (incorporate_penalties): Likew

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Wed, Jan 08 2020, Jan Hubicka wrote: >> Hi, >> >> On Fri, Jan 03 2020, Martin Liška wrote: >> > Hi. >> > >> > This is similar transformation for IPA passes. This time, >> > one needs to use opt_for_fn in order to get the right >> > parameter values. >> > >> > @Martin, Honza: >> > There are

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Wed, Jan 08 2020, Martin Jambor wrote: > Hi, > > On Fri, Jan 03 2020, Martin Liška wrote: >> Hi. >> >> This is similar transformation for IPA passes. This time, >> one needs to use opt_for_fn in order to get the right >> parameter values. >> >> @Martin, Honza: >> There are last few remainin

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi, > > On Fri, Jan 03 2020, Martin Liška wrote: > > Hi. > > > > This is similar transformation for IPA passes. This time, > > one needs to use opt_for_fn in order to get the right > > parameter values. > > > > @Martin, Honza: > > There are last few remaining parameters which should use > > opt_

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi, > > On Wed, Jan 08 2020, Jan Hubicka wrote: > >> Hi, > >> > >> On Fri, Jan 03 2020, Martin Liška wrote: > >> > Hi. > >> > > >> > This is similar transformation for IPA passes. This time, > >> > one needs to use opt_for_fn in order to get the right > >> > parameter values. > >> > > >> > @Mar

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi, > > On Fri, Jan 03 2020, Martin Liška wrote: > > Hi. > > > > This is similar transformation for IPA passes. This time, > > one needs to use opt_for_fn in order to get the right > > parameter values. > > > > @Martin, Honza: > > There are last few remaining parameters which should use > > opt_

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Wed, Jan 08 2020, Jan Hubicka wrote: >> Hi, >> >> On Fri, Jan 03 2020, Martin Liška wrote: >> > Hi. >> > >> > This is similar transformation for IPA passes. This time, >> > one needs to use opt_for_fn in order to get the right >> > parameter values. >> > >> > @Martin, Honza: >> > There are

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Fri, Jan 03 2020, Martin Liška wrote: > Hi. > > This is similar transformation for IPA passes. This time, > one needs to use opt_for_fn in order to get the right > parameter values. > > @Martin, Honza: > There are last few remaining parameters which should use > opt_for_fn: > > param_ipa_ma

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Fri, Jan 03 2020, Martin Liška wrote: > Hi. > > This is similar transformation for IPA passes. This time, > one needs to use opt_for_fn in order to get the right > parameter values. > > @Martin, Honza: > There are last few remaining parameters which should use > opt_for_fn: > > param_ipa_sr

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi, > > On Fri, Jan 03 2020, Martin Liška wrote: > > Hi. > > > > This is similar transformation for IPA passes. This time, > > one needs to use opt_for_fn in order to get the right > > parameter values. > > > > @Martin, Honza: > > There are last few remaining parameters which should use > > opt_

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Fri, Jan 03 2020, Martin Liška wrote: > Hi. > > This is similar transformation for IPA passes. This time, > one needs to use opt_for_fn in order to get the right > parameter values. > > @Martin, Honza: > There are last few remaining parameters which should use > opt_for_fn: > > param_ipa_cp

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi. > > This is similar transformation for IPA passes. This time, > one needs to use opt_for_fn in order to get the right > parameter values. > > @Martin, Honza: > There are last few remaining parameters which should use > opt_for_fn: > > param_ipa_max_agg_items > param_ipa_cp_unit_growth > pa

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Jan Hubicka
> Hi, > > On Fri, Jan 03 2020, Martin Liška wrote: > > Hi. > > > > This is similar transformation for IPA passes. This time, > > one needs to use opt_for_fn in order to get the right > > parameter values. > > > > @Martin, Honza: > > There are last few remaining parameters which should use > > opt_

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-08 Thread Martin Jambor
Hi, On Fri, Jan 03 2020, Martin Liška wrote: > Hi. > > This is similar transformation for IPA passes. This time, > one needs to use opt_for_fn in order to get the right > parameter values. > > @Martin, Honza: > There are last few remaining parameters which should use > opt_for_fn: > > param_ipa_ma