Re: [PATCH] [RISC-V] Fix wrong CFA during stack probe

2025-07-21 Thread Raphael Zinsly
This patch LGTM On Mon, Jul 21, 2025 at 5:24 AM Andreas Schwab wrote: > > I'll add this to clarify: > > temp1 is used by the probe loop for the step size, but we need the final > address of the stack after the loop which resides in temp2. > > -- > Andreas Schwab, SUSE Labs, sch...@suse.de > GPG K

Re: [PATCH] [RISC-V] Fix wrong CFA during stack probe

2025-07-21 Thread Andreas Schwab
I'll add this to clarify: temp1 is used by the probe loop for the step size, but we need the final address of the stack after the loop which resides in temp2. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for someth

Re: [PATCH] [RISC-V] Fix wrong CFA during stack probe

2025-07-19 Thread Jeff Law
On 7/16/25 7:04 AM, Andreas Schwab wrote: PR target/121121 * config/riscv/riscv.cc (riscv_allocate_and_probe_stack_space): Use temp2 instead of temp1 for the CFA note. --- gcc/config/riscv/riscv.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/g