Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-12-05 Thread Jason Merrill
OK, thanks. On Wed, Dec 5, 2018 at 1:32 AM Alexandre Oliva wrote: > > On Nov 29, 2018, Jason Merrill wrote: > > > Let's go with this. And remove the comment. > > > And the !processing_template_decl is also redundant, since that's > > checked at the top of value_dependent_expression_p. > > I've t

Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-12-04 Thread Alexandre Oliva
On Nov 29, 2018, Jason Merrill wrote: > Let's go with this. And remove the comment. > And the !processing_template_decl is also redundant, since that's > checked at the top of value_dependent_expression_p. I've tested this on i686- and x86_64-linux-gnu. Ok to install? [PR86397] resolve nond

Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-11-28 Thread Jason Merrill
On 11/27/18 11:54 PM, Alexandre Oliva wrote: On Nov 27, 2018, Jason Merrill wrote: On 11/22/18 6:40 PM, Alexandre Oliva wrote: Mangling visits the base template function type, prior to template resolution, and on such types, exception specifications may contain unresolved noexcept expressions

Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-11-27 Thread Alexandre Oliva
On Nov 27, 2018, Jason Merrill wrote: > On 11/22/18 6:40 PM, Alexandre Oliva wrote: >> Mangling visits the base template function type, prior to template >> resolution, and on such types, exception specifications may contain >> unresolved noexcept expressions. nothrow_spec_p is called on them >>

Re: [PATCH] [PR86397] set p_t_decl while canonicalizing eh specs for mangling

2018-11-27 Thread Jason Merrill
On 11/22/18 6:40 PM, Alexandre Oliva wrote: Mangling visits the base template function type, prior to template resolution, and on such types, exception specifications may contain unresolved noexcept expressions. nothrow_spec_p is called on them even when exception specifications are not part of