Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-14 Thread James Greenhalgh
On Wed, Jun 14, 2017 at 08:53:27AM +, Hurugalawadi, Naveen wrote: > Hi James, > > >> Could you make the testcase a bit more comprehensive? > > Modified the testcase considering all the possible cases. > Split up the test based on different scenarios. > > Please review the patch and let us k

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-14 Thread Hurugalawadi, Naveen
Hi James, >> Could you make the testcase a bit more comprehensive? Modified the testcase considering all the possible cases. Split up the test based on different scenarios. Please review the patch and let us know if its okay? Thanks, Naveendiff --git a/gcc/config/aarch64/aarch64.c b/gcc/config

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-13 Thread James Greenhalgh
On Tue, Jun 13, 2017 at 10:24:59AM +, Hurugalawadi, Naveen wrote: > Hi James, > > Thanks for your review and useful comments. > > >> If you could try to keep one reply chain for each patch series > Will keep that in mind for sure :-) > > >> Very minor, but what is wrong with: > >> int matche

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-13 Thread Hurugalawadi, Naveen
Hi James, Thanks for your review and useful comments. >> If you could try to keep one reply chain for each patch series Will keep that in mind for sure :-) >> Very minor, but what is wrong with: >> int matches[16][2] = {0}; Done. >> nummatches is unused. Removed. >> This search algorithm is to

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-06-09 Thread James Greenhalgh
On Wed, Apr 26, 2017 at 06:34:36AM +, Hurugalawadi, Naveen wrote: > Hi Kyrill, > > Thanks for the review and your comments. > > >> It would be useful if you expanded a bit on the approach used to > >> generate the improved codegen > > The patch creates a duplicate of most common element and

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-04-25 Thread Hurugalawadi, Naveen
Hi Kyrill, Thanks for the review and your comments. >> It would be useful if you expanded a bit on the approach used to >> generate the improved codegen The patch creates a duplicate of most common element and tries to optimize the insertion using dup for the element followed by insertions. Cur

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-04-25 Thread Kyrill Tkachov
Hi Naveen, On 09/12/16 07:02, Hurugalawadi, Naveen wrote: Hi, Sorry. Missed out the testcase in patch submission. Added the missing testcase along with the ChangeLog. Please review the same and let us know if thats okay? It would be useful if you expanded a bit on the approach used to generat

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-02-05 Thread Hurugalawadi, Naveen
Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-12/msg00718.html Thanks, Naveen

Re: [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2016-12-08 Thread Hurugalawadi, Naveen
Hi, Sorry. Missed out the testcase in patch submission. Added the missing testcase along with the ChangeLog. Please review the same and let us know if thats okay? 2016-12-09  Andrew PInski  gcc     * config/aarch64/aarch64.c (aarch64_expand_vector_init):     Improve vector initializatio