Re: [PATCH][v3] GIMPLE store merging pass

2016-09-13 Thread Kyrill Tkachov
On 08/09/16 16:25, Bernhard Reutner-Fischer wrote: On 8 September 2016 at 10:31, Kyrill Tkachov wrote: On 07/09/16 20:03, Bernhard Reutner-Fischer wrote: On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov wrote: Thanks, fixed all the above in my tree (will be retesting). What about

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-08 Thread Bernhard Reutner-Fischer
On 8 September 2016 at 10:31, Kyrill Tkachov wrote: > > On 07/09/16 20:03, Bernhard Reutner-Fischer wrote: >> >> On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov >> wrote: > Thanks, fixed all the above in my tree (will be retesting). > >> What about debug statements? ISTM you should sk

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-08 Thread Kyrill Tkachov
On 07/09/16 20:03, Bernhard Reutner-Fischer wrote: On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov wrote: Hi all, s/contigous/contiguous/ s/ where where/ where/ +struct merged_store_group +{ + HOST_WIDE_INT start; + HOST_WIDE_INT width; + unsigned char *val; + unsigned int ali

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Jakub Jelinek
On Wed, Sep 07, 2016 at 10:19:11AM +0200, Richard Biener wrote: > > If you want a 64-bit store, you'd need to merge the two, and that would be > > even more expensive. It is a matter of say: > > movl $0x12345678, (%rsp) > > movl $0x09abcdef, 4(%rsp) > > vs. > > movabsq $0x09abcdef12345

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Bernhard Reutner-Fischer
On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov wrote: >Hi all, s/contigous/contiguous/ s/ where where/ where/ +struct merged_store_group +{ + HOST_WIDE_INT start; + HOST_WIDE_INT width; + unsigned char *val; + unsigned int align; + auto_vec stores; + /* We record the first and

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Bernd Schmidt
On 09/07/2016 10:19 AM, Richard Biener wrote: On Tue, 6 Sep 2016, Jakub Jelinek wrote: If you want a 64-bit store, you'd need to merge the two, and that would be even more expensive. It is a matter of say: movl $0x12345678, (%rsp) movl $0x09abcdef, 4(%rsp) vs. movabs

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Jeff Law
On 09/07/2016 02:19 AM, Richard Biener wrote: On Tue, 6 Sep 2016, Jakub Jelinek wrote: On Tue, Sep 06, 2016 at 04:59:23PM +0100, Kyrill Tkachov wrote: On 06/09/16 16:32, Jakub Jelinek wrote: On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: The v3 of this patch addresses feedba

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Richard Biener
On Tue, 6 Sep 2016, Jakub Jelinek wrote: > On Tue, Sep 06, 2016 at 04:59:23PM +0100, Kyrill Tkachov wrote: > > On 06/09/16 16:32, Jakub Jelinek wrote: > > >On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: > > >>The v3 of this patch addresses feedback I received on the version posted

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-06 Thread Kyrill Tkachov
On 06/09/16 17:21, Jakub Jelinek wrote: On Tue, Sep 06, 2016 at 04:59:23PM +0100, Kyrill Tkachov wrote: On 06/09/16 16:32, Jakub Jelinek wrote: On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: The v3 of this patch addresses feedback I received on the version posted at [1]. The

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-06 Thread Jakub Jelinek
On Tue, Sep 06, 2016 at 04:59:23PM +0100, Kyrill Tkachov wrote: > On 06/09/16 16:32, Jakub Jelinek wrote: > >On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: > >>The v3 of this patch addresses feedback I received on the version posted at > >>[1]. > >>The merged store buffer is now r

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-06 Thread Kyrill Tkachov
Hi Jakub, On 06/09/16 16:32, Jakub Jelinek wrote: On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: The v3 of this patch addresses feedback I received on the version posted at [1]. The merged store buffer is now represented as a char array that we splat values onto with native_en

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-06 Thread Jakub Jelinek
On Tue, Sep 06, 2016 at 04:14:47PM +0100, Kyrill Tkachov wrote: > The v3 of this patch addresses feedback I received on the version posted at > [1]. > The merged store buffer is now represented as a char array that we splat > values onto with > native_encode_expr and native_interpret_expr. This a