Re: [PATCH][2/2] early LTO debug, main part

2017-09-21 Thread Jakub Jelinek
On Thu, Sep 21, 2017 at 04:29:34PM +0200, Pierre-Marie de Rodat wrote: > On 09/20/2017 08:08 PM, Jeff Law wrote: > > > As for general DWARF5 testing, I think best coverage is GDB (say guality > > > testing with -gdwarf-5), I think GDB 8.0 should have the needed support. > > > I'll try to install it

Re: [PATCH][2/2] early LTO debug, main part

2017-09-21 Thread Pierre-Marie de Rodat
On 09/20/2017 08:08 PM, Jeff Law wrote: As for general DWARF5 testing, I think best coverage is GDB (say guality testing with -gdwarf-5), I think GDB 8.0 should have the needed support. I'll try to install it (am only at 7.12.1 right now) and try to do some testing. > What about Pierre-Marie's w

Re: [PATCH][2/2] early LTO debug, main part

2017-09-20 Thread Jeff Law
On 09/20/2017 02:31 AM, Jakub Jelinek wrote: > On Wed, Sep 20, 2017 at 10:20:03AM +0200, Richard Biener wrote: >> Anyway, I did a quick LTO bootstrap with your patch and it seems >> to work fine. >> >> Can you add a testcase verifying -gdwarf-5 works ok (properly >> emitting a debug_line_str sectio

Re: [PATCH][2/2] early LTO debug, main part

2017-09-20 Thread Jakub Jelinek
On Wed, Sep 20, 2017 at 10:20:03AM +0200, Richard Biener wrote: > Anyway, I did a quick LTO bootstrap with your patch and it seems > to work fine. > > Can you add a testcase verifying -gdwarf-5 works ok (properly > emitting a debug_line_str section?). I'm afraid I can't. We don't have a command

Re: [PATCH][2/2] early LTO debug, main part

2017-09-20 Thread Richard Biener
On Tue, 19 Sep 2017, Jakub Jelinek wrote: > On Tue, Sep 19, 2017 at 05:24:14PM +0200, Jakub Jelinek wrote: > > These changes broke DWARF-5 support. E.g. in gcc-7 and before this change > > there was: Sorry for the breakage I had to manually merge conflicts in this part quite a few times since th

Re: [PATCH][2/2] early LTO debug, main part

2017-09-19 Thread Jakub Jelinek
On Tue, Sep 19, 2017 at 05:24:14PM +0200, Jakub Jelinek wrote: > These changes broke DWARF-5 support. E.g. in gcc-7 and before this change > there was: Here is a fix, make check-g++ RUNTESTFLAGS=dwarf2.exp now passes again even with !DWARF2_ASM_LINE_DEBUG_INFO compiler. Haven't tried LTO (except

Re: [PATCH][2/2] early LTO debug, main part

2017-09-19 Thread Jakub Jelinek
On Fri, Aug 04, 2017 at 02:21:29PM +0200, Richard Biener wrote: > ! /* Initialize the various sections and labels for dwarf output. */ > > static void > ! init_sections_and_labels (void) ... These changes broke DWARF-5 support. E.g. in gcc-7 and before this change there was: > ! if (!dw

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Richard Biener
On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 22/08/17 11:17, Richard Biener wrote: > > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > >> on aarch64_be-none-elf i see > >> > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) > >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Szabolcs Nagy
On 22/08/17 11:17, Richard Biener wrote: > On Tue, 22 Aug 2017, Szabolcs Nagy wrote: >> on aarch64_be-none-elf i see >> >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 (test for excess errors) >> PASS->FAIL: gcc.dg/debug/pr41893-1.c -gdwarf-2 -O (test for excess errors) >> PASS->FAIL: gcc.dg/debu

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Richard Biener
On Tue, 22 Aug 2017, Szabolcs Nagy wrote: > On 04/08/17 13:21, Richard Biener wrote: > > On Thu, 3 Aug 2017, Jason Merrill wrote: > >> OK if testing passes. > > > > Thanks. Meanwhile testing passed. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > > on x86_64-unkn

Re: [PATCH][2/2] early LTO debug, main part

2017-08-22 Thread Szabolcs Nagy
On 04/08/17 13:21, Richard Biener wrote: > On Thu, 3 Aug 2017, Jason Merrill wrote: >> OK if testing passes. > > Thanks. Meanwhile testing passed. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, LTO bootstrapped > on x86_64-unknown-linux-gnu (both all languages). I've successfully > bu

Re: [PATCH][2/2] early LTO debug, main part

2017-08-04 Thread Richard Biener
On Thu, 3 Aug 2017, Jason Merrill wrote: > On Thu, Aug 3, 2017 at 6:51 AM, Richard Biener wrote: > > On Wed, 2 Aug 2017, Jason Merrill wrote: > > > >> On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > >> > On Wed, 2 Aug 2017, Jason Merrill wrote: > >> > > >> >> On 05/19/2017 06:42 AM, Rich

Re: [PATCH][2/2] early LTO debug, main part

2017-08-03 Thread Jason Merrill
On Thu, Aug 3, 2017 at 6:51 AM, Richard Biener wrote: > On Wed, 2 Aug 2017, Jason Merrill wrote: > >> On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: >> > On Wed, 2 Aug 2017, Jason Merrill wrote: >> > >> >> On 05/19/2017 06:42 AM, Richard Biener wrote: >> >> > + /* ??? In some cases th

Re: [PATCH][2/2] early LTO debug, main part

2017-08-03 Thread Richard Biener
On Wed, 2 Aug 2017, Jason Merrill wrote: > On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > > On Wed, 2 Aug 2017, Jason Merrill wrote: > > > >> On 05/19/2017 06:42 AM, Richard Biener wrote: > >> > + /* ??? In some cases the C++ FE (at least) fails to > >> > +set DECL_CONTEXT p

Re: [PATCH][2/2] early LTO debug, main part

2017-08-02 Thread Jason Merrill
On Wed, Aug 2, 2017 at 6:35 AM, Richard Biener wrote: > On Wed, 2 Aug 2017, Jason Merrill wrote: > >> On 05/19/2017 06:42 AM, Richard Biener wrote: >> > + /* ??? In some cases the C++ FE (at least) fails to >> > +set DECL_CONTEXT properly. Simply globalize stuff >> > +in this

Re: [PATCH][2/2] early LTO debug, main part

2017-08-02 Thread Richard Biener
On Wed, 2 Aug 2017, Jason Merrill wrote: > On 05/19/2017 06:42 AM, Richard Biener wrote: > > + /* ??? In some cases the C++ FE (at least) fails to > > +set DECL_CONTEXT properly. Simply globalize stuff > > +in this case. For example > > +__dso_handle created via iost

Re: [PATCH][2/2] early LTO debug, main part

2017-08-01 Thread Jason Merrill
On 05/19/2017 06:42 AM, Richard Biener wrote: + /* ??? In some cases the C++ FE (at least) fails to +set DECL_CONTEXT properly. Simply globalize stuff +in this case. For example +__dso_handle created via iostream line 74 col 25. */ + parent = comp_unit_die ();

Re: [PATCH][2/2] early LTO debug, main part

2017-07-04 Thread Richard Biener
On Tue, 20 Jun 2017, Richard Biener wrote: > On Wed, 7 Jun 2017, Richard Biener wrote: > > > On Fri, 19 May 2017, Richard Biener wrote: > > > > > > > > This is a repost of the main part of the early LTO debug support. > > > The only changes relative to the last post is in the dwarf2out.c > > >

Re: [PATCH][2/2] early LTO debug, main part

2017-06-20 Thread Richard Biener
On Wed, 7 Jun 2017, Richard Biener wrote: > On Fri, 19 May 2017, Richard Biener wrote: > > > > > This is a repost of the main part of the early LTO debug support. > > The only changes relative to the last post is in the dwarf2out.c > > pieces due to Jasons review and Jakubs introduction of > > D

Re: [PATCH][2/2] early LTO debug, main part

2017-06-07 Thread Richard Biener
On Fri, 19 May 2017, Richard Biener wrote: > > This is a repost of the main part of the early LTO debug support. > The only changes relative to the last post is in the dwarf2out.c > pieces due to Jasons review and Jakubs introduction of > DW_OP_GNU_variable_value. > > I've also adjusted testcase