Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-08 Thread Ilya Enkovich
On 07 Apr 22:43, Jan Hubicka wrote: > > > > 2015-04-07 Ilya Enkovich > > > > * tree-chkp.c (chkp_find_const_bounds_var): Remove. > > (chkp_make_static_const_bounds): Search existing > > symbol by assembler name. Use make_decl_one_only. > > > > gcc/testsuite/ > > > > 2015-04-07

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-07 Thread Jan Hubicka
> > 2015-04-07 Ilya Enkovich > > * tree-chkp.c (chkp_find_const_bounds_var): Remove. > (chkp_make_static_const_bounds): Search existing > symbol by assembler name. Use make_decl_one_only. > > gcc/testsuite/ > > 2015-04-07 Ilya Enkovich > > * gcc.dg/lto/chkp-stati

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-07 Thread Ilya Enkovich
On 03 Apr 19:01, Jan Hubicka wrote: > > Sadly I think this won't work on targets that adds prefix to assembler name, > like djgpp/mingw. > To obtain mangled assembler name you need to call > id = targetm.mangle_decl_assembler_name (decl, DECL_NAME (decl)); > that in turn requires decl to already e

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-03 Thread Jan Hubicka
> > Thanks a lot for looking into it! Seems originally I mostly got problems due > to no DECL_WEAK for generated var, make_decl_one_only seems to work for my > tests. Will run more testing to make sure it's OK. Here is a new patch > version. Is it OK? Good ;) > diff --git a/gcc/tree-chkp.c

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-03 Thread Ilya Enkovich
On 02 Apr 22:45, Jan Hubicka wrote: > > Hi, > > > > Current in LTO static const bounds are created as external symbol. It > > doesn't work in case original symbols were removed and privatized. This > > patch introduces a separate comdat symbol to be used in LTO. Bootstrapped > > and tested

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-02 Thread Jan Hubicka
> Hi, > > Current in LTO static const bounds are created as external symbol. It > doesn't work in case original symbols were removed and privatized. This > patch introduces a separate comdat symbol to be used in LTO. Bootstrapped > and tested on x86_64-unknown-linux-gnu. Does this approach