Re: [GSoC] use obstack in parse_c_expr

2014-05-13 Thread Richard Biener
On Fri, May 9, 2014 at 10:30 PM, Jeff Law wrote: > On 04/25/14 05:39, Prathamesh Kulkarni wrote: >> >> On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo >> wrote: >>> >>> Please remember to send patches to gcc-patches. >>> >>> I'm wondering if you couldn't just use std::string here. No need to >>>

Re: [GSoC] use obstack in parse_c_expr

2014-05-09 Thread Jeff Law
On 04/25/14 05:39, Prathamesh Kulkarni wrote: On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: Please remember to send patches to gcc-patches. I'm wondering if you couldn't just use std::string here. No need to change one complicated allocation scheme with another. Since we were using c

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Richard Biener
On Fri, Apr 25, 2014 at 2:01 PM, Trevor Saunders On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: >> On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: >> > Please remember to send patches to gcc-patches. >> > >> > I'm wondering if you couldn't just use std::string here. N

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Trevor Saunders
On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: > On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: > > Please remember to send patches to gcc-patches. > > > > I'm wondering if you couldn't just use std::string here. No need to change > > one complicated allocation scheme

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Prathamesh Kulkarni
On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: > Please remember to send patches to gcc-patches. > > I'm wondering if you couldn't just use std::string here. No need to change > one complicated allocation scheme with another. Since we were using c-styled strings throughout genmatch, I thou