Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

On 07/08/2014 02:21 AM, Tobias Burnus wrote: > Cesar Philippidis wrote: >> Thomas, is this OK for gomp-4_0-branch? > ... > > >> * gcc/fortran/scanner.c (gfc_next_char_literal): Fix the scan for >> *$acc. > > This changes looks good to me. > >> * parse.c (next_fixed): Don't handle

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

Cesar Philippidis wrote: > Thomas, is this OK for gomp-4_0-branch? ... > * gcc/fortran/scanner.c (gfc_next_char_literal): Fix the scan for > *$acc. This changes looks good to me. > * parse.c (next_fixed): Don't handle openmp pragmas when scanning > for openacc pragmas.

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

On 07/04/2014 01:40 AM, Thomas Schwinge wrote: > On Wed, 02 Jul 2014 14:53:19 +0200, I wrote: >> I understand the attached fixed.f to be well-formed fixed-form Fortran >> code, but it fails to parse in OpenACC mode: > > The legacy of Fortran ;-) strikes again: > > $ gcc/xgcc -Bgcc/ -Bx86_64-

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

On 07/03/2014 10:01 AM, Thomas Schwinge wrote: > I'm happy to, but why don't we just get you set up? You're covered by > the general Mentor Graphics/CodeSourcery copyright assignment. Please > request an account per , and on >

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

Hi Cesar! On Wed, 2 Jul 2014 17:27:48 -0700, Cesar Philippidis wrote: > Thomas, is this patch ok for gomp-4_0-branch? Tobias has approved the patch (and I'm confirming it does fix the issue); thanks to you and Tobias for looking into this! > If so, please check it in. I'm happy to, but why d

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

Cesar Philippidis wrote: I couldn't find anything obvious in gcc/fortran/parse.c; is someone able to have a more in-depth look than I have? First, some minor point, I think one should crosswise reset the {openmp,openacc}_flag, i.e. --- a/gcc/fortran/scanner.c +++ b/gcc/fortran/scanner.c @@ -735

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

On 07/02/2014 12:02 PM, Tobias Burnus wrote: > Thomas Schwinge wrote: >> In -fopenmp mode as well as in combined -fopenacc -fopenmp mode as >> well as in "regular" (no -fopen*) mode, it parses fine. > > [Note I am testing with an outdated branch (20140404), but it still > might be representative.]