Re: [C++ Patch] Fix c++/56243

2013-02-28 Thread Jason Merrill
On 02/25/2013 06:25 PM, Jason Merrill wrote: On 02/25/2013 06:24 PM, Jason Merrill wrote: I think my preference would be to avoid calling fixed_type_or_null at all when we're in a template. I already changed resolves_to_fixed_type_p that way, now we need to fix build_vtbl_ref_1. Oops, now I s

Re: [C++ Patch] Fix c++/56243

2013-02-26 Thread Jason Merrill
On 02/25/2013 06:25 PM, Jason Merrill wrote: On 02/25/2013 06:24 PM, Jason Merrill wrote: I think my preference would be to avoid calling fixed_type_or_null at all when we're in a template. I already changed resolves_to_fixed_type_p that way, now we need to fix build_vtbl_ref_1. Oops, now I s

Re: [C++ Patch] Fix c++/56243

2013-02-25 Thread Jason Merrill
On 02/25/2013 06:24 PM, Jason Merrill wrote: I think my preference would be to avoid calling fixed_type_or_null at all when we're in a template. I already changed resolves_to_fixed_type_p that way, now we need to fix build_vtbl_ref_1. Oops, now I see the discussion on the PR. I'll take a look

Re: [C++ Patch] Fix c++/56243

2013-02-25 Thread Jason Merrill
I think my preference would be to avoid calling fixed_type_or_null at all when we're in a template. I already changed resolves_to_fixed_type_p that way, now we need to fix build_vtbl_ref_1. For post 4.8 we might avoid messing with vtables at all when we're in a template. Jason