Re: RFC - Refactor tree.h

2013-09-16 Thread Jakub Jelinek
On Mon, Sep 16, 2013 at 09:39:27AM -0400, Diego Novillo wrote: > On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo wrote: > > On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > > > >> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN > >> comment that has been added to tree.h re

Re: RFC - Refactor tree.h

2013-09-16 Thread Diego Novillo
On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo wrote: > On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > >> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN >> comment that has been added to tree.h recently, but you haven't >> actually moved it into tree-core.h. > > Sorry

Re: RFC - Refactor tree.h

2013-09-13 Thread Andrew MacLeod
Rap Diego's knuckles for that :-) Bad Diego. Andrew On 09/13/2013 11:07 AM, Jakub Jelinek wrote: On Thu, Sep 05, 2013 at 11:11:43AM +0200, Richard Biener wrote: On Thu, Sep 5, 2013 at 2:06 AM, Mike Stump wrote: On Aug 30, 2013, at 4:22 PM, Diego Novillo wrote: Thanks for the suggestions

Re: RFC - Refactor tree.h

2013-09-13 Thread Diego Novillo
On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN > comment that has been added to tree.h recently, but you haven't > actually moved it into tree-core.h. Sorry about that. I remember an update conflict, but I thought I had i

Re: RFC - Refactor tree.h

2013-09-13 Thread Jakub Jelinek
On Thu, Sep 05, 2013 at 11:11:43AM +0200, Richard Biener wrote: > On Thu, Sep 5, 2013 at 2:06 AM, Mike Stump wrote: > > On Aug 30, 2013, at 4:22 PM, Diego Novillo wrote: > >> Thanks for the suggestions. I've incorporated them into the patch. > >> It now adds tree-core.h with all the structures,

Re: RFC - Refactor tree.h

2013-09-05 Thread Richard Biener
On Thu, Sep 5, 2013 at 2:06 AM, Mike Stump wrote: > On Aug 30, 2013, at 4:22 PM, Diego Novillo wrote: >> Thanks for the suggestions. I've incorporated them into the patch. >> It now adds tree-core.h with all the structures, enums, typedefs and >> some fundamental declarations from tree.h. Every

Re: RFC - Refactor tree.h

2013-09-04 Thread Mike Stump
On Aug 30, 2013, at 4:22 PM, Diego Novillo wrote: > Thanks for the suggestions. I've incorporated them into the patch. > It now adds tree-core.h with all the structures, enums, typedefs and > some fundamental declarations from tree.h. Everything else stays in > tree.h for now. So, the comments

Re: RFC - Refactor tree.h

2013-09-02 Thread Richard Biener
On Sat, Aug 31, 2013 at 1:22 AM, Diego Novillo wrote: > Thanks for the suggestions. I've incorporated them into the patch. > It now adds tree-core.h with all the structures, enums, typedefs and > some fundamental declarations from tree.h. Everything else stays in > tree.h for now. > > As we conv

Re: RFC - Refactor tree.h

2013-08-22 Thread Andrew MacLeod
On 08/21/2013 05:13 PM, Mike Stump wrote: O that should include the tree-core.h file as well as the tree-api.h file. No… I don't see a client for tree-api. Logically, you can segregate them down at the bottom of tree-core.h. We are then left with this tree-api.h file which will be included

Re: RFC - Refactor tree.h

2013-08-21 Thread Mike Stump
On Aug 21, 2013, at 10:23 AM, Andrew MacLeod wrote: > On 08/10/2013 06:03 AM, Richard Biener wrote: >> Mike Stump wrote: >>> On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: This patch is still WIP. It builds stage1, but I'm getting ICEs during stage 2. The patch splits tre

Re: RFC - Refactor tree.h

2013-08-21 Thread Andrew MacLeod
On 08/10/2013 06:03 AM, Richard Biener wrote: Mike Stump wrote: On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: This patch is still WIP. It builds stage1, but I'm getting ICEs during stage 2. The patch splits tree.h into three files: - tree-core.h: All data structures, enums and typedefs

Re: RFC - Refactor tree.h

2013-08-12 Thread Mike Stump
On Aug 11, 2013, at 1:00 AM, Richard Biener wrote: > Fact is that we need to separate internal details of tree.h into sth > shareable from exactly two places. Tree-core.h and tree.h are both 'tree.h' > in some way. Call it tree-internal.h or tree1.h. 1 is also a bad category; internal or core

Re: RFC - Refactor tree.h

2013-08-11 Thread Richard Biener
Mike Stump wrote: >On Aug 10, 2013, at 3:03 AM, Richard Biener > wrote: >> Mike Stump wrote: >>> On Aug 9, 2013, at 3:36 PM, Diego Novillo >wrote: This patch is still WIP. It builds stage1, but I'm getting ICEs during stage 2. The patch splits tree.h into three files:

Re: RFC - Refactor tree.h

2013-08-10 Thread Mike Stump
On Aug 10, 2013, at 3:03 AM, Richard Biener wrote: > Mike Stump wrote: >> On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: >>> This patch is still WIP. It builds stage1, but I'm getting ICEs >>> during stage 2. >>> >>> The patch splits tree.h into three files: >>> >>> - tree-core.h: All data

Re: RFC - Refactor tree.h

2013-08-10 Thread Richard Biener
Mike Stump wrote: >On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: >> This patch is still WIP. It builds stage1, but I'm getting ICEs >> during stage 2. >> >> The patch splits tree.h into three files: >> >> - tree-core.h: All data structures, enums and typedefs from >> tree.h >> >> - tree-a

Re: RFC - Refactor tree.h

2013-08-09 Thread Mike Stump
On Aug 9, 2013, at 3:36 PM, Diego Novillo wrote: > This patch is still WIP. It builds stage1, but I'm getting ICEs > during stage 2. > > The patch splits tree.h into three files: > > - tree-core.h: All data structures, enums and typedefs from > tree.h > > - tree-api.h: All extern function def