Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-28 Thread Richard Earnshaw
On 27/11/13 18:35, Jeff Law wrote: > On 11/27/13 03:19, Yvan Roux wrote: >> Ping. >> >> On 20 November 2013 10:22, Yvan Roux wrote: >>> Hi, >>> >>> as Richard said, only a subset of rclass is allowed to be returned by >>> preferred_reload_class. > I don't think he was quite that definitive. "One

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Yvan Roux
> I don't think he was quite that definitive. "One reading of the manual > suggests ...". However, Richard's interpretation is the same as I've had > for eons. You can return the original class, a narrower class or NO_REGS. Yes, I also read the manual and discussed the patch with Richard offlin

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Jeff Law
On 11/27/13 03:19, Yvan Roux wrote: Ping. On 20 November 2013 10:22, Yvan Roux wrote: Hi, as Richard said, only a subset of rclass is allowed to be returned by preferred_reload_class. I don't think he was quite that definitive. "One reading of the manual suggests ...". However, Richard's i

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Richard Earnshaw
On 20/11/13 09:22, Yvan Roux wrote: > Hi, > > as Richard said, only a subset of rclass is allowed to be returned by > preferred_reload_class. I've tested the attached patched in Thumb > mode, on ARMv5, A9 and A9hf and on cross A15 without regression. > > Yvan > > 2013-11-20 Yvan Roux > >

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-27 Thread Yvan Roux
Ping. On 20 November 2013 10:22, Yvan Roux wrote: > Hi, > > as Richard said, only a subset of rclass is allowed to be returned by > preferred_reload_class. I've tested the attached patched in Thumb > mode, on ARMv5, A9 and A9hf and on cross A15 without regression. > > Yvan > > 2013-11-20 Yvan R

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-20 Thread Yvan Roux
Hi, as Richard said, only a subset of rclass is allowed to be returned by preferred_reload_class. I've tested the attached patched in Thumb mode, on ARMv5, A9 and A9hf and on cross A15 without regression. Yvan 2013-11-20 Yvan Roux PR target/58785 * config/arm/arm.c (arm_pref

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-10-30 Thread Richard Earnshaw (home)
On 30 Oct 2013, at 08:16, "Vladimir Makarov" wrote: > The following patch fixes: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58785 > > LRA chooses constraint 'm' for const_int operand. It means that the > const_int should be placed in memory but it does not happen as preferred > reload c

RFA: patch to fix PR58785 (an ARM LRA crash)

2013-10-30 Thread Vladimir Makarov
The following patch fixes: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58785 LRA chooses constraint 'm' for const_int operand. It means that the const_int should be placed in memory but it does not happen as preferred reload class hook returns LO_REGS for class NO_REGS which is result of LRA