Re: RFA: PATCH to add id_strcmp helper function

2017-06-09 Thread Richard Biener
On June 9, 2017 10:07:36 PM GMT+02:00, Jason Merrill wrote: >On Tue, May 23, 2017 at 5:52 PM, Jason Merrill >wrote: >> On Thu, May 18, 2017 at 11:03 PM, Martin Sebor >wrote: >>> On 05/18/2017 08:30 PM, Jason Merrill wrote: I got tired of writing strcmp (IDENTIFIER_POINTER and decided t

Re: RFA: PATCH to add id_strcmp helper function

2017-06-09 Thread Jason Merrill
On Tue, May 23, 2017 at 5:52 PM, Jason Merrill wrote: > On Thu, May 18, 2017 at 11:03 PM, Martin Sebor wrote: >> On 05/18/2017 08:30 PM, Jason Merrill wrote: >>> >>> I got tired of writing strcmp (IDENTIFIER_POINTER and decided to wrap >>> it in an inline function. I decided to use "id_strcmp" i

Re: RFA: PATCH to add id_strcmp helper function

2017-05-23 Thread Jason Merrill
On Thu, May 18, 2017 at 11:03 PM, Martin Sebor wrote: > On 05/18/2017 08:30 PM, Jason Merrill wrote: >> >> I got tired of writing strcmp (IDENTIFIER_POINTER and decided to wrap >> it in an inline function. I decided to use "id_strcmp" instead of >> just overloading strcmp, but I don't feel strong

Re: RFA: PATCH to add id_strcmp helper function

2017-05-18 Thread Martin Sebor
On 05/18/2017 08:30 PM, Jason Merrill wrote: I got tired of writing strcmp (IDENTIFIER_POINTER and decided to wrap it in an inline function. I decided to use "id_strcmp" instead of just overloading strcmp, but I don't feel strongly about that choice. The second patch changes all existing uses o

RFA: PATCH to add id_strcmp helper function

2017-05-18 Thread Jason Merrill
I got tired of writing strcmp (IDENTIFIER_POINTER and decided to wrap it in an inline function. I decided to use "id_strcmp" instead of just overloading strcmp, but I don't feel strongly about that choice. The second patch changes all existing uses of that pattern to use the new function. OK for