[sell...@mips.com]
Sent: Friday, July 12, 2013 3:22 PM
To: joern.renne...@embecosm.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFA: Fix rtl-optimization/57425 (SPEC perl problem on MIPS)
Joern,
Has anyone reported any problems to you about this patch? I am running into
a problem running the perl
Joern,
Has anyone reported any problems to you about this patch? I am running into
a problem running the perl benchmark from SPEC2006 and I have tracked it down
to this June 16 patch (SVN 200133,
GIT ddba76b84c757d93b4247713d558724776149b62). I am building a GCC cross
compiler running on x86 lin
On Wed, Jun 19, 2013 at 9:58 PM, Joern Rennecke
wrote:
> Quoting Michael Matz :
>
>> That's not good. You now have different order of parameters between
>> anti_dependence and canon_anti_dependence. That will be mightily
>> confusing, please instead change the caller. Currently these predicates
Quoting Michael Matz :
That's not good. You now have different order of parameters between
anti_dependence and canon_anti_dependence. That will be mightily
confusing, please instead change the caller. Currently these predicates
take their arguments in the order of the corresponding instructio
On Wed, 19 Jun 2013, Joern Rennecke wrote:
> > I.e. the arguments after your patch are exactly swapped. This is usually
> > harmless, but not always, so that should be corrected before check in.
> > The change in cselib.c:cselib_invalidate_mem has the same problem.
>
> Well, I have already commi
I.e. the arguments after your patch are exactly swapped. This is usually
harmless, but not always, so that should be corrected before check in.
The change in cselib.c:cselib_invalidate_mem has the same problem.
Well, I have already committed the patch, so attached is a patch to fix
things up.
L
Quoting Michael Matz :
So, first the potentially clobbering write, then the read. And indeed in
check_dependence d->exp is the write and x the read that is potentially
clobbered.
Oops, you are right. I got confused because what is X in cse.c:invalidate
ends up as d->exp in cse.c:check_depend
On Sun, 16 Jun 2013, Joern Rennecke wrote:
> Quoting Eric Botcazou :
>
> > Could you also check that your patch also fixes PR opt/57569 and, if so, add
> > the reference to the ChangeLog as well as the testcase?
>
> Attached is what I'm currently testing. bootstrap on i686-pc-linux-gnu
> finishe
Quoting Eric Botcazou :
Could you also check that your patch also fixes PR opt/57569 and, if so, add
the reference to the ChangeLog as well as the testcase?
Attached is what I'm currently testing. bootstrap on i686-pc-linux-gnu
finished, now regtesting.
On x86_64-pc-linux-gnu, bootstrap is sti
Quoting Eric Botcazou :
The patch is OK on principle but I think that we should use the same
interface
for write_dependence_p as for true_dependence_1, i.e. add a mem_mode
parameter
instead of a mem_size and add both mem_addr and mem_canonicalized (and since
it doesn't seem that we need x_
> Bootstrapped/regtested on i686-pc-linux-gnu.
For the record, and as you diagnosed, the change proposed in
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00367.html
means that we must now be very careful with memory dependency checking in the
various RTL optimization passes. Another example is
Bootstrapped/regtested on i686-pc-linux-gnu.
2013-06-15 Joern Rennecke
gcc:
PR rtl-optimization/57425
* alias.c (write_dependence_p): Add new parameters mem_size and
canon_mem_addr. Changed all callers.
(canon_anti_dependence): New function.
* cse.c (che
12 matches
Mail list logo
