Re: RFA: 4.9 gimple-fold PATCH for c++/62224

2014-09-08 Thread Jan Hubicka
> On 09/08/2014 03:51 PM, Jan Hubicka wrote: > >You did not attach the patch. > > Oops. OK, thanks! Honza > > > commit e57303b73d20fa75ffc535bbc219dc0f6472e431 > Author: Jason Merrill > Date: Mon Sep 8 13:11:58 2014 -0400 > > PR c++/61214 > PR c++/62224 > gcc/ > * gim

Re: RFA: 4.9 gimple-fold PATCH for c++/62224

2014-09-08 Thread Jason Merrill
On 09/08/2014 03:51 PM, Jan Hubicka wrote: You did not attach the patch. Oops. commit e57303b73d20fa75ffc535bbc219dc0f6472e431 Author: Jason Merrill Date: Mon Sep 8 13:11:58 2014 -0400 PR c++/61214 PR c++/62224 gcc/ * gimple-fold.c (can_refer_decl_in_current_unit_p): Do

Re: RFA: 4.9 gimple-fold PATCH for c++/62224

2014-09-08 Thread Jan Hubicka
> My fix for 61214 to clear DECL_EXTERNAL on inline virtual functions > when devirtualizing caused 62224: devirtualizing and inlining such a > function in the testcase causes an additional external reference, > which in the submitter's library is to a hidden symbol. > > I think this is what we wan

RFA: 4.9 gimple-fold PATCH for c++/62224

2014-09-08 Thread Jason Merrill
My fix for 61214 to clear DECL_EXTERNAL on inline virtual functions when devirtualizing caused 62224: devirtualizing and inlining such a function in the testcase causes an additional external reference, which in the submitter's library is to a hidden symbol. I think this is what we want for 5.