Re: [libitm] Link with -litm and -pthread

On 02/14/2012 11:58 PM, Eric Botcazou wrote: >> I see several new fails on s390x with that patch (r184174): > > People should realize that -fgnu-tm doesn't really work if libitm hasn't been > ported to the architecture, for example s390/s390x. My understanding is that > Hans-Peter's patch shoul

RE: [libitm] Link with -litm and -pthread

To: Jack Howarth > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [libitm] Link with -litm and -pthread > > >I missed the regeneration of libitm/configure the first time. The > > p2.diff with the regenerated libitm/configure passes make check in > libitm > > now on

Re: [libitm] Link with -litm and -pthread

> I see several new fails on s390x with that patch (r184174): People should realize that -fgnu-tm doesn't really work if libitm hasn't been ported to the architecture, for example s390/s390x. My understanding is that Hans-Peter's patch should have taken care of this now. -- Eric Botcazou

Re: [libitm] Link with -litm and -pthread

On 14 Feb 2012, at 16:08, Andreas Krebbel wrote: On 02/11/2012 03:14 PM, Eric Botcazou wrote: Hi, this completes the half-implemented linking scheme of libitm and makes it mimic that of libgomp entirely. We need the -pthread thing on Solaris 8. Tested on SPARC/Solaris 8 & 9 and i586/Linu

Re: [libitm] Link with -litm and -pthread

On 02/11/2012 03:14 PM, Eric Botcazou wrote: > Hi, > > this completes the half-implemented linking scheme of libitm and makes it > mimic > that of libgomp entirely. We need the -pthread thing on Solaris 8. > > Tested on SPARC/Solaris 8 & 9 and i586/Linux, OK for the mainline? > > > 2012-02-1

Re: [libitm] Link with -litm and -pthread

On Tue, 14 Feb 2012, Eric Botcazou wrote: > > It broke all targets that don't implement threads and as such > > don't support -pthread. And you need to gate *all* tm-related > > tests on something like check_effective_target_pthread. > > The question is, how is libitm supposed to work on these sys

Re: [libitm] Link with -litm and -pthread

> It broke all targets that don't implement threads and as such > don't support -pthread. And you need to gate *all* tm-related > tests on something like check_effective_target_pthread. The question is, how is libitm supposed to work on these systems? The configure.ac file contains: # Check to

Re: [libitm] Link with -litm and -pthread

On Sat, 11 Feb 2012, Eric Botcazou wrote: > Hi, > > this completes the half-implemented linking scheme of libitm and makes it > mimic > that of libgomp entirely. We need the -pthread thing on Solaris 8. It broke all targets that don't implement threads and as such don't support -pthread. And yo

Re: [libitm] Link with -litm and -pthread

On 02/11/2012 06:14 AM, Eric Botcazou wrote: > 2012-02-11 Eric Botcazou > > * gcc.c (LINK_COMMAND_SPEC): Deal with -fgnu-tm. > (GTM_SELF_SPECS): Define if not already defined. > (driver_self_specs): Add GTM_SELF_SPECS. > * config/darwin.h (GTM_SELF_SPECS): Define. >

Re: [libitm] Link with -litm and -pthread

On Sat, Feb 11, 2012 at 08:23:45PM +0100, Eric Botcazou wrote: > >I missed the regeneration of libitm/configure the first time. The > > p2.diff with the regenerated libitm/configure passes make check in libitm > > now on x86_64-apple-darwin11... > > Great, thanks for the testing. Eric, The

Re: [libitm] Link with -litm and -pthread

>I missed the regeneration of libitm/configure the first time. The > p2.diff with the regenerated libitm/configure passes make check in libitm > now on x86_64-apple-darwin11... Great, thanks for the testing. -- Eric Botcazou

Re: [libitm] Link with -litm and -pthread

On Sat, Feb 11, 2012 at 07:11:11PM +0100, Eric Botcazou wrote: > > Applied to gcc trunk (r184130) along with the proposed fix for > > Bug libitm/52042... > > OK, I missed the hardcoded(!) spec in config/darwin.h for libgomp, so I guess > we need the same thing for libitm. Revised patch attac

Re: [libitm] Link with -litm and -pthread

Hi Eric, On 11 Feb 2012, at 14:14, Eric Botcazou wrote: Hi, this completes the half-implemented linking scheme of libitm and makes it mimic that of libgomp entirely. We need the -pthread thing on Solaris 8. Tested on SPARC/Solaris 8 & 9 and i586/Linux, OK for the mainline? 2012-02-11 E

Re: [libitm] Link with -litm and -pthread

>FYI, if I restore -litm to the linkage of the failing tests, they > compile and run fine. I don't understand why we think -litm can be dropped > from linking the tests in the libitm testsuite. Because -fgnu-tm will automatically add it on the link line, like for -fopenmp. -- Eric Botcazou

Re: [libitm] Link with -litm and -pthread

> Applied to gcc trunk (r184130) along with the proposed fix for > Bug libitm/52042... OK, I missed the hardcoded(!) spec in config/darwin.h for libgomp, so I guess we need the same thing for libitm. Revised patch attached. * config/darwin.h (LINK_COMMAND_SPEC_A): Deal with -fgnu-t

Re: [libitm] Link with -litm and -pthread

On Sat, Feb 11, 2012 at 06:54:05PM +0100, Eric Botcazou wrote: > > This change causes massive failures at -m32/-m64 on x86_64-apple-darwin11 > > in the libitm testsuite... > > How did you test it? > > -- > Eric Botcazou Eric, FYI, if I restore -litm to the linkage of the failing tests, they

Re: [libitm] Link with -litm and -pthread

On Sat, Feb 11, 2012 at 06:54:05PM +0100, Eric Botcazou wrote: > > This change causes massive failures at -m32/-m64 on x86_64-apple-darwin11 > > in the libitm testsuite... > > How did you test it? > > -- > Eric Botcazou Eric, Applied to gcc trunk (r184130) along with the proposed fix for Bu

Re: [libitm] Link with -litm and -pthread

> This change causes massive failures at -m32/-m64 on x86_64-apple-darwin11 > in the libitm testsuite... How did you test it? -- Eric Botcazou

Re: [libitm] Link with -litm and -pthread

On Sat, Feb 11, 2012 at 03:14:40PM +0100, Eric Botcazou wrote: > Hi, > > this completes the half-implemented linking scheme of libitm and makes it > mimic > that of libgomp entirely. We need the -pthread thing on Solaris 8. > > Tested on SPARC/Solaris 8 & 9 and i586/Linux, OK for the mainline?