RE: [RFC v2] bpf.2: Use standard types and attributes

2021-05-05 Thread Joseph Myers
On Wed, 5 May 2021, David Laight via Libc-alpha wrote: > > __u64 can't be formatted with %llu on all architectures. That's not > > true for uint64_t, where you have to use %lu on some architectures to > > avoid compiler warnings (and technically undefined behavior). There are > > preprocessor ma

RE: [RFC v2] bpf.2: Use standard types and attributes

2021-05-05 Thread David Laight via Gcc-patches
From: Florian Weimer > Sent: 04 May 2021 20:46 > > * Alejandro Colomar: > > > The thing is, in all of those threads, the only reasons to avoid > > types in the kernel (at least, the only explicitly > > mentioned ones) are (a bit simplified, but this is the general idea of > > those threads): > >

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alexei Starovoitov via Gcc-patches
On Tue, May 4, 2021 at 1:33 PM Zack Weinberg wrote: > the information that should > appear in the manpages is the information that is most relevant to > user space programmers. The bpf programs are compiled for the kernel and run in the kernel. Hence bpf man pages must reflect the kernel. Also th

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Zack Weinberg
On Tue, May 4, 2021 at 4:06 PM Daniel Borkmann wrote: > > I'm trying to clarify the manual pages as much as possible, by using > > standard conventions and similar structure all around the pages. Not > > everyone understands kernel conventions. Basically, Zack said very much > > what I had in

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alejandro Colomar (man-pages) via Gcc-patches
Hi Daniel, On 5/4/21 10:06 PM, Daniel Borkmann wrote: On 5/4/21 6:08 PM, Daniel Borkmann wrote:  >  > But what /problem/ is this really solving? Why bother to change this /now/  > after so many years?! I think this is causing more confusion than solving  > anything, really. Moreover, what ar

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Daniel Borkmann
On 5/4/21 8:54 PM, Alejandro Colomar (man-pages) wrote: On 5/4/21 6:06 PM, Greg KH wrote: > There's a very old post from Linus where he describes the difference > between things like __u32 and uint32_t.  They are not the same, they > live in different namespaces, and worlds, and can not always

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alejandro Colomar (man-pages) via Gcc-patches
Hi Florian, On 5/4/21 9:45 PM, Florian Weimer wrote: * Alejandro Colomar: The thing is, in all of those threads, the only reasons to avoid types in the kernel (at least, the only explicitly mentioned ones) are (a bit simplified, but this is the general idea of those threads): * Possibly brea

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Florian Weimer via Gcc-patches
* Alejandro Colomar: > The thing is, in all of those threads, the only reasons to avoid > types in the kernel (at least, the only explicitly > mentioned ones) are (a bit simplified, but this is the general idea of > those threads): > > * Possibly breaking something in such a big automated change.

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alejandro Colomar (man-pages) via Gcc-patches
Hi Greg, Daniel, On 5/4/21 6:06 PM, Greg KH wrote: > There's a very old post from Linus where he describes the difference > between things like __u32 and uint32_t. They are not the same, they > live in different namespaces, and worlds, and can not always be swapped > out for each other on all ar

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Zack Weinberg
On Tue, May 4, 2021 at 12:06 PM Greg KH wrote: > On Tue, May 04, 2021 at 05:53:29PM +0200, Alejandro Colomar (man-pages) wrote: > > On 5/4/21 4:24 PM, Greg KH wrote: > > > I agree, the two are not the same type at all, this change should not be > > > accepted. > > > > I get that in the kernel you

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Daniel Borkmann
On 5/4/21 5:53 PM, Alejandro Colomar (man-pages) wrote: Hi Greg and Alexei, On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: For the same reasons as explained earlier: Nacked-by: Alexei Starovoitov Okay, I'll add that. On 5/4/21 4:24 PM, Greg KH wrote:> I agree, the two

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Greg KH via Gcc-patches
On Tue, May 04, 2021 at 05:53:29PM +0200, Alejandro Colomar (man-pages) wrote: > Hi Greg and Alexei, > > > On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: > > > For the same reasons as explained earlier: > > > Nacked-by: Alexei Starovoitov > > Okay, I'll add that. > > > On

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alejandro Colomar (man-pages) via Gcc-patches
Hi Greg and Alexei, On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: For the same reasons as explained earlier: Nacked-by: Alexei Starovoitov Okay, I'll add that. On 5/4/21 4:24 PM, Greg KH wrote:> I agree, the two are not the same type at all, this change should not be

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Greg KH via Gcc-patches
On Tue, May 04, 2021 at 07:12:01AM -0700, Alexei Starovoitov wrote: > On Tue, May 4, 2021 at 4:05 AM Alejandro Colomar > wrote: > > > > Some manual pages are already using C99 syntax for integral > > types 'uint32_t', but some aren't. There are some using kernel > > syntax '__u32'. Fix those. >

Re: [RFC v2] bpf.2: Use standard types and attributes

2021-05-04 Thread Alexei Starovoitov via Gcc-patches
On Tue, May 4, 2021 at 4:05 AM Alejandro Colomar wrote: > > Some manual pages are already using C99 syntax for integral > types 'uint32_t', but some aren't. There are some using kernel > syntax '__u32'. Fix those. > > Some pages also document attributes, using GNU syntax > '__attribute__((xxx))'