RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, 2015-06-29 at 12:07 -0700, Matthew Fortune wrote: > If nobody can identify any further functional issues with this patch then > I'd like to get this committed and pursue enhancements as a second round. > Catherine, would you be happy for this to be committed on that basis? > > Thanks, > M

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, Jun 29, 2015 at 6:08 PM, Maciej W. Rozycki wrote: > Richard, please have a look at my question below in a reference to your > previous statement. > > On Thu, 18 Jun 2015, Steve Ellcey wrote: > >> OK, I checked in the prequel patch and here is a new copy of the >> original patch based off o

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

.gnu.org > Subject: RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused- > madd > > Maciej W. Rozycki writes: > > Richard, please have a look at my question below in a reference to > > your previous statement. > > > > On Thu, 18 Jun 2015, Steve Ellc

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

Maciej W. Rozycki writes: > Richard, please have a look at my question below in a reference to your > previous statement. > > On Thu, 18 Jun 2015, Steve Ellcey wrote: > > > OK, I checked in the prequel patch and here is a new copy of the > > original patch based off of that (and with no HONOR_NA

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

Richard, please have a look at my question below in a reference to your previous statement. On Thu, 18 Jun 2015, Steve Ellcey wrote: > OK, I checked in the prequel patch and here is a new copy of the > original patch based off of that (and with no HONOR_NAN checks in the > fma/madd instructions)

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Thu, 2015-06-18 at 13:04 +0100, Maciej W. Rozycki wrote: > > This change looks good to me, I have no objections. Thanks. > > Maciej OK, I checked in the prequel patch and here is a new copy of the original patch based off of that (and with no HONOR_NAN checks in the fma/madd instructions

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 17 Jun 2015, Matthew Fortune wrote: > > Here is my "prequel" patch. How does this look? > > > > Steve Ellcey > > sell...@imgtec.com > > > > 2015-06-17 Steve Ellcey > > > > * config/mips/mips.c (mips_rtx_costs): Remove HONOR_NAN check. > > * config/mips/mips.md (*madd4): Ditt

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 17 Jun 2015, Richard Sandiford wrote: > and the one mips-ps-3d.md: > > (define_expand "mips_abs_ps" > [(set (match_operand:V2SF 0 "register_operand") > (unspec:V2SF [(match_operand:V2SF 1 "register_operand")] >UNSPEC_ABS_PS))] > "TARGET_HARD_FLOAT && TARGET_P

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

Steve Ellcey writes: > On Wed, 2015-06-17 at 19:44 +0100, Richard Sandiford wrote: > > > > > FWIW, to be specific, I think we're talking about every check except > > the last two in mips.md: > > > > and the one mips-ps-3d.md: > > > > In particular, the two checks in mips.c should go. > > OK, her

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 2015-06-17 at 19:44 +0100, Richard Sandiford wrote: > > FWIW, to be specific, I think we're talking about every check except > the last two in mips.md: > > and the one mips-ps-3d.md: > > In particular, the two checks in mips.c should go. OK, here is a patch that does that. > But like

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 2015-06-17 at 19:17 +0100, Maciej W. Rozycki wrote: > On Wed, 17 Jun 2015, Steve Ellcey wrote: > > FAOD I meant to remove the checks globally throughout MIPS target code > only. > > > Is there any reason why my patch (minus the HONOR_NAN checks) would have > > to wait for the other chan

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

"Maciej W. Rozycki" writes: > On Wed, 17 Jun 2015, Steve Ellcey wrote: >> Well, I don't mind removing the HONOR_NAN checks from the MIPS code in >> my patch but I am not sure I can do a patch to remove it from the shared >> code. I see about 80 HONOR_NAN checks in the shared code and I am not >>

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 17 Jun 2015, Steve Ellcey wrote: > Well, I don't mind removing the HONOR_NAN checks from the MIPS code in > my patch but I am not sure I can do a patch to remove it from the shared > code. I see about 80 HONOR_NAN checks in the shared code and I am not > sure which ones can and cannot be

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Wed, 2015-06-17 at 11:41 +0100, Richard Sandiford wrote: > "Maciej W. Rozycki" writes: > > In that case I think the HONOR_NANS checks will best be globally removed > > first (where applicable of course), with a separate preparatory change. > > With a comment though :-) I.e. say that althoug

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

"Maciej W. Rozycki" writes: > In that case I think the HONOR_NANS checks will best be globally removed > first (where applicable of course), with a separate preparatory change. With a comment though :-) I.e. say that although NEG is the IEEE negate operation, we don't need to honour NaNs in th

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Tue, 16 Jun 2015, Maciej W. Rozycki wrote: > On Tue, 16 Jun 2015, Joseph Myers wrote: > > > > Furthermore these checks were deliberately introduced by Richard with > > > his > > > proposal here > > > and agreed upon in the discussio

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Tue, 16 Jun 2015, Joseph Myers wrote: > > Furthermore these checks were deliberately introduced by Richard with his > > proposal here > > and agreed upon in the discussion even before IEEE Std 754-2008 has been > > made. Are you sug

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Tue, 16 Jun 2015, Maciej W. Rozycki wrote: > This makes me wonder however what the point has been to specify a strict > particular semantics for the copy, negate, abs, copySign operations with > respect to the sign bit of qNaN data where any other operation can then > change the bit in a ra

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, 15 Jun 2015, Joseph Myers wrote: > > > It is only required (well, recommended) to pass the *payload*. The sign > > > bit is not part of the payload. "For all other operations, this standard > > > does not specify the sign bit of a NaN result, even when there is only > > > one > > > i

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, 15 Jun 2015, Maciej W. Rozycki wrote: > > It is only required (well, recommended) to pass the *payload*. The sign > > bit is not part of the payload. "For all other operations, this standard > > does not specify the sign bit of a NaN result, even when there is only one > > input NaN,

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, 15 Jun 2015, Joseph Myers wrote: > > operands negated. That negation, implemented with the IEEE Std 754-2008 > > `negate' operation that you referred to, by definition is required to > > operate on the sign of its operand in a specific way even if the operand > > is a qNaN. > > > > S

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Mon, 15 Jun 2015, Maciej W. Rozycki wrote: > operands negated. That negation, implemented with the IEEE Std 754-2008 > `negate' operation that you referred to, by definition is required to > operate on the sign of its operand in a specific way even if the operand > is a qNaN. > > So for e

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Thu, 11 Jun 2015, Joseph Myers wrote: > > loongson and r8000 have the most changes, they no longer generate msub > > instructions with -mfused-madd because that instruction does not generate > > the correct NAN in some cases (the sign may be wrong). If HONOR_NANS > > is not set then they will

Re: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

On Thu, 11 Jun 2015, Steve Ellcey wrote: > loongson and r8000 have the most changes, they no longer generate msub > instructions with -mfused-madd because that instruction does not generate > the correct NAN in some cases (the sign may be wrong). If HONOR_NANS > is not set then they will genera