RE: [PATCH v1 1/2] Genmatch: Support new flow for phi on condition

2024-09-04 Thread Li, Pan2
: Richard Biener Sent: Wednesday, September 4, 2024 6:56 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; tamar.christ...@arm.com; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; rdapp@gmail.com Subject: Re: [PATCH v1 1/2] Genmatch: Support new flow for phi on condition On Wed, Se

Re: [PATCH v1 1/2] Genmatch: Support new flow for phi on condition

2024-09-04 Thread Richard Biener
pb_0_1, 0)->src == EDGE_PRED (_pb_1_1, 0)->src) ... I also think we may want to split out this CFG matching code out into a helper function in gimple-match-head.cc instead of repeating it fully for each pattern? Thanks, Richard. > Pan > > -Original Message- > From: Richa

RE: [PATCH v1 1/2] Genmatch: Support new flow for phi on condition

2024-09-04 Thread Li, Pan2
i_arg_def (_a1, _arg_0_is_true_1 ? 1 : 0); Pan -Original Message- From: Richard Biener Sent: Wednesday, September 4, 2024 3:42 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; tamar.christ...@arm.com; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; rdapp@gmail.com Subject:

Re: [PATCH v1 1/2] Genmatch: Support new flow for phi on condition

2024-09-04 Thread Richard Biener
On Wed, Sep 4, 2024 at 9:25 AM wrote: > > From: Pan Li > > The gen_phi_on_cond can only support below control flow for cond > from day 1. Aka: > > +--+ > | def | > | ... | +-+ > | cond |-->| def | > +--+ | ... | >| +-+ >| | >v