Hi Matthew,
> One small tweak, ChangeLog should wrap at 74 columns.
Done.
> Please consider the
> full list of authors for this patch as it has had many major contributors
> now. I believe this includes at least the following for the implementation
> but fewer for the testsuite updates:
>
> Rob
Hi Robert,
Robert Suchanek writes:
> Revised patch attached.
>
> Tested with mips-img-linux-gnu and bootstrapped x86_64-unknown-linux-
> gnu.
One small tweak, ChangeLog should wrap at 74 columns. Please consider the
full list of authors for this patch as it has had many major contributors
now.
Hi Matthew,
Revised patch attached.
Tested with mips-img-linux-gnu and bootstrapped x86_64-unknown-linux-gnu.
> > mips_gen_const_int_vector
> This should use gen_int_for_mode instead of GEN_INT to avoid the issues that
> msa_ldi is
> trying to handle.
gen_int_mode cannot be used to generate a v
Hi Robert,
Apologies for the long delay again. This patch is hard to get through. My
comments
are not all in source sequence but I've tried to keep them short. With a few
minor
things fixed and some trivial style issues done then this is ready to go. I've
left
a number of things to look at afte
Hi Robert,
Thanks for the update and detailed comments. There are a couple of things
which I think still need addressing based solely on your comments but
generally the changes seem to have simplified things which is nice to see.
I haven't read the patch again yet and given the changes it looks l
Hi,
Here is the updated patch for MSA. The patch requires updated MSA tests
and preparatory patch that reorders function types.
Tested on mips-img-linux-gnu and mips-mti-linux-gnu.
Regards,
Robert
gcc/ChangeLog:
* config.gcc: Add MSA header file for mips*-*-* target.
* config/
Hi,
Comments inlined.
> >+;; The attribute gives half modes for vector modes.
> >+(define_mode_attr VHMODE
> >+ [(V8HI "V16QI")
> >+ (V4SI "V8HI")
> >+ (V2DI "V4SI")
> >+ (V2DF "V4SF")])
> >+
> >+;; The attribute gives double modes for vector modes.
> >+(define_mode_attr VDMODE
> >+ [(V4S
Hi,
Comments inlined. The updated patch will be sent in another email
as this message is already long.
> Hi Robert,
>
> Next batch of comments. This set covers the rest of mips-msa.md.
>
> >+++ b/gcc/config/mips/mips-msa.md
> >+(define_expand "vec_perm"
> >+ [(match_operand:MSA 0 "register_ope
Hi,
Comments inlined.
> >diff --git a/gcc/config/mips/constraints.md b/gcc/config/mips/constraints.md
> >index 7d1a8ba..cde0196 100644
> >--- a/gcc/config/mips/constraints.md
> >+++ b/gcc/config/mips/constraints.md
> >@@ -308,6 +308,53 @@ (define_constraint "Yx"
> >"@internal"
> >(match_o
Hi Robert,
Next batch of comments. This set covers the rest of mips-msa.md.
>+++ b/gcc/config/mips/mips-msa.md
>+(define_expand "vec_perm"
>+ [(match_operand:MSA 0 "register_operand")
>+ (match_operand:MSA 1 "register_operand")
>+ (match_operand:MSA 2 "register_operand")
>+ (match_operand:
Hi Robert,
Next batch of comments for this patch. I've covered mips-msa.md up to the copy
patterns and one supporting function from mips.c.
>+++ b/gcc/config/mips/mips-msa.md
>+;; The attribute gives half modes for vector modes.
>+(define_mode_attr VHMODE
>+ [(V8HI "V16QI")
>+ (V4SI "V8HI")
>
Hi Robert,
I'm taking small steps at this review. I did the first few files as below.
mips-msa.md is next so don't expect the it quickly. I might do that in pieces
too.
No need to post an updated patch until I'm all the way through but I'd
appreciate an explicit ok/done to each point or discussio
12 matches
Mail list logo
