Re: [PATCH 05/10] i386: Fix dot_prod backend patterns for mmx and sse targets

2024-07-12 Thread Victor Do Nascimento
On 7/12/24 03:23, Jiang, Haochen wrote: -Original Message- From: Hongtao Liu Sent: Thursday, July 11, 2024 9:45 AM To: Victor Do Nascimento Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com; richard.earns...@arm.com Subject: Re: [PATCH 05/10] i386: Fix dot_prod backend patterns

RE: [PATCH 05/10] i386: Fix dot_prod backend patterns for mmx and sse targets

2024-07-11 Thread Jiang, Haochen
> -Original Message- > From: Hongtao Liu > Sent: Thursday, July 11, 2024 9:45 AM > To: Victor Do Nascimento > Cc: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com; > richard.earns...@arm.com > Subject: Re: [PATCH 05/10] i386: Fix dot_prod backend patterns for

Re: [PATCH 05/10] i386: Fix dot_prod backend patterns for mmx and sse targets

2024-07-10 Thread Hongtao Liu
On Wed, Jul 10, 2024 at 10:10 PM Victor Do Nascimento wrote: > > Following the migration of the dot_prod optab from a direct to a > conversion-type optab, ensure all back-end patterns incorporate the > second machine mode into pattern names. The patch LGTM. BTW you can use existing instead of new