Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Mon, 31 Oct 2022, Jan Hubička wrote: > Hello, > thanks for checking the performance. The patch is OK. Thanks, pushed the attached patch, and working on a corresponding change for floating-point divisions. AlexanderFrom 1962a8b22d3d3fb5b6bb5598295a4571daf8876f Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

Hello, thanks for checking the performance. The patch is OK. Honza On Mon, Oct 31, 2022 at 11:39 AM Joshi, Tejas Sanjay < tejassanjay.jo...@amd.com> wrote: > [Public] > > Hi, > > > It is not latency. It is reciprocal throughput. For example, the > multiplication instruction has > > latency 3 and

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

[Public] Hi, > It is not latency. It is reciprocal throughput. For example, the > multiplication instruction has > latency 3 and reciprocal throughput 1, and the corresponding execution unit > can accept a new > multiplication instruction each cycle. In the .md file we are modeling that > by s

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Wed, 26 Oct 2022, Kumar, Venkataramanan wrote: > > Looking at znver1.md again, I think the problem is caused by incorrect > > modeling of division instructions: they have descriptions like > > > > (define_insn_reservation "znver1_idiv_DI" 41 > > (and (eq_attr "cpu" "znve

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

; Joshi, Tejas Sanjay > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD > Zen4 CPU > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

[Public] Hi, On Mon, Oct 24, 2022 at 4:26 PM Alexander Monakov wrote: > > > This grew insn-automata.cc from 201502 lines to 639968 lines and the > > > build of the automata (genautomata) to several minutes in my dev tree. > > > > Yeah, in my unoptimized non-bootstrapp

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Mon, 24 Oct 2022, Jan Hubička wrote: > > By the way, it appears pre-existing znver[123] models are also causing > > some kind > > of combinatorial blow-up, but before znver4 it was not a blocking issue: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87832 > > > It is really easy to make

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Mon, Oct 24, 2022 at 4:26 PM Alexander Monakov wrote: > > > > This grew insn-automata.cc from 201502 lines to 639968 lines and the > > > > build of the automata (genautomata) to several minutes in my dev > tree. > > > > > > Yeah, in my unoptimized non-bootstrapped development tree genautomata

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

> > > This grew insn-automata.cc from 201502 lines to 639968 lines and the > > > build of the automata (genautomata) to several minutes in my dev tree. > > > > Yeah, in my unoptimized non-bootstrapped development tree genautomata > > now takes over 12 minutes on a fast box, that is simply not accep

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

ail.com > Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD > Zen4 CPU > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Fri, Oct 21, 2022 at 01:51:55PM

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Fri, Oct 21, 2022 at 01:51:55PM +0200, Richard Biener via Gcc-patches wrote: > > > > BTW: Perhaps znver1.md is not the right filename anymore, since it hosts > > > all four Zen schedulers. > > > > > > I have renamed the file to znver.md in this revision, PFA. > > > Thank you for the review, we w

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

[Public] Hi all, > Okay, I will prepare another patch which reverts the znver4 instruction > reservations and submit it. PFA the patch which reverts the znver4 instruction reservations. I have also made znver4 to use znver3 scheduler for now. If its good for the trunk, I will submit it. Thanks

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

[AMD Official Use Only - General] Hi, > I think it may make sense to make the initial patch without scheduler model > update with zen3 scheduling. I can work on updating the model which needs > some benchmarking and setting up > the cost tables first. > The problem here is that adding extra va

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

c.gnu.org > > > Cc: Kumar, Venkataramanan ; > > > honza.hubi...@gmail.com; Uros Bizjak > > > Subject: RE: [PATCH] [X86_64]: Enable support for next generation AMD > > > Zen4 CPU > > > > > > [Public] > > > > > > Hi, > > &g

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

nan ; > > honza.hubi...@gmail.com; Uros Bizjak > > Subject: RE: [PATCH] [X86_64]: Enable support for next generation AMD > > Zen4 CPU > > > > [Public] > > > > Hi, > > > > > BTW: Perhaps znver1.md is not the right filename anymore, since it host

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

Hi all, > -Original Message- > From: Joshi, Tejas Sanjay > Sent: Monday, October 17, 2022 8:09 PM > To: gcc-patches@gcc.gnu.org > Cc: Kumar, Venkataramanan ; > honza.hubi...@gmail.com; Uros Bizjak > Subject: RE: [PATCH] [X86_64]: Enable support for next gene

RE: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

[Public] Hi, > BTW: Perhaps znver1.md is not the right filename anymore, since it hosts all > four Zen schedulers. I have renamed the file to znver.md in this revision, PFA. Thank you for the review, we will push it for trunk if we don't get any further comments. Thanks and Regards, Tejas 0

Re: [PATCH] [X86_64]: Enable support for next generation AMD Zen4 CPU

On Thu, Oct 13, 2022 at 5:33 PM Joshi, Tejas Sanjay wrote: > > [Public] > > Hi all, > > PFA, the patch that enables support for the next generation AMD Zen4 CPU via > -march=znver4. > This is a basic enablement patch and as of now the costings, tunings are kept > same as znver3. > > Good for tru