Re: [EXTERNAL] Re: [PATCH] [tree-optimization] Fix for PR97223

2020-11-05 Thread Jeff Law via Gcc-patches
On 10/29/20 1:45 PM, Eugene Rozenfeld via Gcc-patches wrote: > Thank you for the review Richard! > > I re-worked the patch based on your suggestions. I combined the two patterns. > Neither one requires a signedness check as long as the type of the 'add' has > overflow wrap semantics. > > I had

Re: [EXTERNAL] Re: [PATCH] [tree-optimization] Fix for PR97223

2020-10-30 Thread Richard Biener via Gcc-patches
On Thu, Oct 29, 2020 at 8:45 PM Eugene Rozenfeld wrote: > > Thank you for the review Richard! > > I re-worked the patch based on your suggestions. I combined the two patterns. > Neither one requires a signedness check as long as the type of the 'add' has > overflow wrap semantics. > > I had to m

RE: [EXTERNAL] Re: [PATCH] [tree-optimization] Fix for PR97223

2020-10-29 Thread Eugene Rozenfeld via Gcc-patches
Thank you for the review Richard! I re-worked the patch based on your suggestions. I combined the two patterns. Neither one requires a signedness check as long as the type of the 'add' has overflow wrap semantics. I had to modify the regular expression in no-strict-overflow-4.c test. In that t