Re: Question on adding an option control to libcpp

Okay. thanks, I will add testing cases. Qing > On May 28, 2019, at 4:26 PM, David Malcolm wrote: > > On Tue, 2019-05-28 at 15:08 -0500, Qing Zhao wrote: >> Hi, David, >> >> for this new option, do I need to add a new testing case for it? > > Yes please. Ideally we should add at least one tes

Re: Question on adding an option control to libcpp

On Tue, 2019-05-28 at 15:08 -0500, Qing Zhao wrote: > Hi, David, > > for this new option, do I need to add a new testing case for it? Yes please. Ideally we should add at least one test case for any new option, especially if it's easy to test for. > if so, where should I put this new testing ca

Re: Question on adding an option control to libcpp

Hi, David, for this new option, do I need to add a new testing case for it? if so, where should I put this new testing case? thanks. Qing > On May 24, 2019, at 1:47 PM, David Malcolm wrote: > > On Fri, 2019-05-24 at 11:59 -0500, Qing Zhao wrote: >> Hi, >> >> in order to fix PR90581: (provide

Re: Question on adding an option control to libcpp

Hi, David, this is helpful. thanks. Qing > On May 24, 2019, at 1:47 PM, David Malcolm wrote: > > On Fri, 2019-05-24 at 11:59 -0500, Qing Zhao wrote: >> Hi, >> >> in order to fix PR90581: (provide an option to adjust the maximum >> depth of nested #include) >> >> https://gcc.gnu.org/bugzilla

Re: Question on adding an option control to libcpp

On Fri, 2019-05-24 at 11:59 -0500, Qing Zhao wrote: > Hi, > > in order to fix PR90581: (provide an option to adjust the maximum > depth of nested #include) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 rg/bugzilla/show_bug.cgi?id=90581> > > we need to add a new opt

Question on adding an option control to libcpp

Hi, in order to fix PR90581: (provide an option to adjust the maximum depth of nested #include) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 we need to add a new option to preprocessor. where should I put this option? I tried to add