Re: Patch RFC: disable block partitioning with split stack

2017-06-11 Thread Ian Lance Taylor
On Sun, Jun 11, 2017 at 2:38 AM, Jan Hubicka wrote: >> > >> > Thanks for explanation. Perhaps we could have this documented, because >> > otherwise people will think the option is simply broken. I guess even >> > better >> > we could have configure autodetection for the broken linker. >> >> Comm

Re: Patch RFC: disable block partitioning with split stack

2017-06-11 Thread Jan Hubicka
> > > > Thanks for explanation. Perhaps we could have this documented, because > > otherwise people will think the option is simply broken. I guess even better > > we could have configure autodetection for the broken linker. > > Committed to mainline with docs as follows. Thanks, the patch howev

Re: Patch RFC: disable block partitioning with split stack

2017-06-09 Thread Ian Lance Taylor
On Fri, Jun 9, 2017 at 11:22 AM, Jan Hubicka wrote: >> On Fri, Jun 9, 2017 at 3:16 AM, Jan Hubicka wrote: >> > >> >> code compiled with -fsplit-stack, if the cold partition calls a >> >> function that is not compiled with -fsplit-stack (such as a C library >> >> function). The problem is that wh

Re: Patch RFC: disable block partitioning with split stack

2017-06-09 Thread Jan Hubicka
> On Fri, Jun 9, 2017 at 3:16 AM, Jan Hubicka wrote: > > > >> code compiled with -fsplit-stack, if the cold partition calls a > >> function that is not compiled with -fsplit-stack (such as a C library > >> function). The problem is that when the linker sees a split-stack > >> function call a non-

Re: Patch RFC: disable block partitioning with split stack

2017-06-09 Thread Ian Lance Taylor
On Fri, Jun 9, 2017 at 3:16 AM, Jan Hubicka wrote: > >> code compiled with -fsplit-stack, if the cold partition calls a >> function that is not compiled with -fsplit-stack (such as a C library >> function). The problem is that when the linker sees a split-stack >> function call a non-split-stack

Re: Patch RFC: disable block partitioning with split stack

2017-06-09 Thread Jan Hubicka
> This recent patch > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00518.html turned on > block partitioning even when profiling is not enabled. This can break I am heading towards enabling block partitioning by default (because we now have infrastructure to identify likely cold BBs), but I must

Re: Patch RFC: disable block partitioning with split stack

2017-06-09 Thread Richard Biener
On Fri, Jun 9, 2017 at 7:14 AM, Ian Lance Taylor wrote: > This recent patch > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00518.html turned on > block partitioning even when profiling is not enabled. This can break > code compiled with -fsplit-stack, if the cold partition calls a > function tha

Patch RFC: disable block partitioning with split stack

2017-06-08 Thread Ian Lance Taylor
This recent patch https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00518.html turned on block partitioning even when profiling is not enabled. This can break code compiled with -fsplit-stack, if the cold partition calls a function that is not compiled with -fsplit-stack (such as a C library function)