Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Kirill Yukhin
On 30 May 13:45, Jakub Jelinek wrote: > On Fri, May 30, 2014 at 03:41:22PM +0400, Kirill Yukhin wrote: > > That is definetely a bug and I see no compatibility issues in the fix. > > > > The only nit I see: maybe it'd be better to put this cpuid-less intrinsic > > into immintin.h? xmmintrin.h serve

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Jakub Jelinek
On Fri, May 30, 2014 at 03:41:22PM +0400, Kirill Yukhin wrote: > That is definetely a bug and I see no compatibility issues in the fix. > > The only nit I see: maybe it'd be better to put this cpuid-less intrinsic > into immintin.h? xmmintrin.h serves for SSE. Wouldn't that be an API compatibilit

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Kirill Yukhin
Hello Ian, Uroš, On 30 May 09:19, Uros Bizjak wrote: > Hello! > > > This error is because _mm_pause is defined in the scope of #pragma GCC > > target("sse"). But _mm_pause, which simply generates the pause > > instruction, does not require SSE support. The pause instruction has > > nothing reall

Re: Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-30 Thread Uros Bizjak
Hello! > This error is because _mm_pause is defined in the scope of #pragma GCC > target("sse"). But _mm_pause, which simply generates the pause > instruction, does not require SSE support. The pause instruction has > nothing really to do with SSE, and it works on all x86 processors (on > proces

Patch RFA: Move x86 _mm_pause out of pragma target("sse") scope

2014-05-29 Thread Ian Lance Taylor
The _mm_pause intrinsic is defined in xmmintrin.h. Right now using it with -m32 with the default -march option gives an error: /home/iant/foo.c: In function ‘f’: /home/iant/gcc/go-install/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/include/xmmintrin.h:1238:1: error: inlining failed in call to always