Re: Patch RFA: Fix for c++/50012

2012-01-13 Thread Jason Merrill
On 01/13/2012 05:48 PM, Ian Lance Taylor wrote: * typeck.c (enum_cast_to_uint): New static function. Shouldn't this be "enum_cast_to_int", since the promotion is to integer_type_node? OK with that change. Jason

Patch RFA: Fix for c++/50012

2012-01-13 Thread Ian Lance Taylor
PR c++/50012 shows a case where we do not issue a -Wsign-compare warning when we should. I introduced this problem here: 2009-06-25 Ian Lance Taylor * call.c (avoid_sign_compare_warnings): New static function. (build_new_op): Call it. * typeck.c (cp_build_binary_op): D