Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Mon, 20 Apr 2015, Thomas Schwinge wrote: > Gerald, is it OK to commit the following to update GCC 5 changes' »New > Languages and Language specific improvements« section? Sure thing. Gerald

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! > > Note that this is an experimental feature, incomplete, and subject to > cha

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch) (PR65742)

On Tue, 14 Apr 2015 15:15:02 +0100 Julian Brown wrote: > On Wed, 8 Apr 2015 17:58:56 +0300 > Ilya Verbin wrote: > > > On Wed, Apr 08, 2015 at 15:31:42 +0100, Julian Brown wrote: > > > This version is mostly the same as the last posted version but > > > has a tweak in GOACC_parallel to account f

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

> (Not asking for review just yet, JFYI.) This is not a review! but the patch fixes PR65742. Dominique

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, 8 Apr 2015 17:58:56 +0300 Ilya Verbin wrote: > On Wed, Apr 08, 2015 at 15:31:42 +0100, Julian Brown wrote: > > This version is mostly the same as the last posted version but has a > > tweak in GOACC_parallel to account for the new splay tree > > arrangement for target functions: > > > >

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, 8 Apr 2015 17:58:56 +0300 Ilya Verbin wrote: > Have you tested it with disabled offloading? > > I see several regressions: > FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/acc_on_device-1.c > -DACC_DEVICE_TYPE_host_nonshm=1 -DACC_MEM_SHARED=0 execution test > FAIL: libgomp.oacc-c/../l

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 08, 2015 at 15:31:42 +0100, Julian Brown wrote: > This version is mostly the same as the last posted version but has a > tweak in GOACC_parallel to account for the new splay tree arrangement > for target functions: > > - tgt_fn = (void (*)) tgt_fn_key->tgt->tgt_start; > + tgt

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 08, 2015 at 03:31:42PM +0100, Julian Brown wrote: > It passes libgomp testing on NVPTX. OK? Please write a proper ChangeLog entry for it. Ok with that. Jakub

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Tue, 7 Apr 2015 17:26:45 +0200 Jakub Jelinek wrote: > On Mon, Apr 06, 2015 at 03:45:57PM +0300, Ilya Verbin wrote: > > On Wed, Apr 01, 2015 at 15:20:25 +0200, Jakub Jelinek wrote: > > > LGTM with proper ChangeLog entry. > > > > I've commited this patch into trunk. > > > > Julian, you probabl

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, Apr 06, 2015 at 03:45:57PM +0300, Ilya Verbin wrote: > On Wed, Apr 01, 2015 at 15:20:25 +0200, Jakub Jelinek wrote: > > LGTM with proper ChangeLog entry. > > I've commited this patch into trunk. > > Julian, you probably want to update the nvptx plugin. Note that as the number of P1s with

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 01, 2015 at 15:20:25 +0200, Jakub Jelinek wrote: > LGTM with proper ChangeLog entry. I've commited this patch into trunk. Julian, you probably want to update the nvptx plugin. gcc/ * config/i386/intelmic-mkoffload.c (generate_host_descr_file): Call GOMP_offload_unreg

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 01, 2015 at 15:20:25 +0200, Jakub Jelinek wrote: > On Wed, Apr 01, 2015 at 04:14:05PM +0300, Ilya Verbin wrote: > > I was worried about the following scenario: > > 1. Thread 1 in GOMP_target locks device 1. > > 2. Thread 2 in GOMP_target locks device 2 and calls gomp_fatal. > > 3. GOMP_

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 01, 2015 at 04:14:05PM +0300, Ilya Verbin wrote: > On Wed, Apr 01, 2015 at 07:21:47 +0200, Jakub Jelinek wrote: > > On Wed, Apr 01, 2015 at 02:53:28AM +0300, Ilya Verbin wrote: > > > +/* Similar to gomp_fatal, but release mutexes before. */ > > > + > > > +static void > > > +gomp_fatal_

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 01, 2015 at 07:21:47 +0200, Jakub Jelinek wrote: > On Wed, Apr 01, 2015 at 02:53:28AM +0300, Ilya Verbin wrote: > > +/* Similar to gomp_fatal, but release mutexes before. */ > > + > > +static void > > +gomp_fatal_unlock (const char *fmt, ...) > > +{ > > + int i; > > + va_list list; >

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Apr 01, 2015 at 02:53:28AM +0300, Ilya Verbin wrote: > +/* Similar to gomp_fatal, but release mutexes before. */ > + > +static void > +gomp_fatal_unlock (const char *fmt, ...) > +{ > + int i; > + va_list list; > + > + for (i = 0; i < num_devices; i++) > +gomp_mutex_unlock (&devices[

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Tue, Mar 31, 2015 at 19:10:36 +0300, Ilya Verbin wrote: > Ok, thanks for the clarification! Here is the new patch with variables. > > Unfortunately I see 4 fails in make check-target-libgomp with PTX patch > applied > on top, but with disabled offloading to PTX. > Julian, have you seen them?

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Tue, Mar 31, 2015 at 09:25:26PM +0300, Ilya Verbin wrote: > On Mon, Mar 30, 2015 at 18:42:02 +0200, Jakub Jelinek wrote: > > Shouldn't either this function, or gomp_offload_image_to_device lock > > also devicep->lock mutex and unlock at the end? > > Where exactly I guess depends on if the device

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, Mar 30, 2015 at 18:42:02 +0200, Jakub Jelinek wrote: > Shouldn't either this function, or gomp_offload_image_to_device lock > also devicep->lock mutex and unlock at the end? > Where exactly I guess depends on if the devicep->* hook calls should be > guarded with the mutex or not. If yes, i

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Tue, Mar 31, 2015 at 15:07:58 +0200, Jakub Jelinek wrote: > On Tue, Mar 31, 2015 at 03:52:06PM +0300, Ilya Verbin wrote: > > > What is the reason to register and allocate these one at a time, rather > > > than > > > using one struct target_mem_desc with one tgt->array for all splay tree > > > n

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Tue, Mar 31, 2015 at 03:52:06PM +0300, Ilya Verbin wrote: > > What is the reason to register and allocate these one at a time, rather than > > using one struct target_mem_desc with one tgt->array for all splay tree > > nodes registered from one image? > > Perhaps you would just use tgt_start of

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, Mar 30, 2015 at 22:42:51 +0100, Julian Brown wrote: > On Mon, 30 Mar 2015 18:42:02 +0200 > Jakub Jelinek wrote: > > But the one Julian posted doesn't apply on top of your patch. > > If there is any interdiff needed on top of your patch, can it be > > posted against trunk + your patch? > >

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, 30 Mar 2015 18:42:02 +0200 Jakub Jelinek wrote: > On Thu, Mar 26, 2015 at 11:41:30PM +0300, Ilya Verbin wrote: > > Here is the latest patch for libgomp and mic plugin. > > make check-target-libgomp using intelmic emul passed. > > Also I used a testcase from the attachment. > > This appli

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Thu, Mar 26, 2015 at 11:41:30PM +0300, Ilya Verbin wrote: > Here is the latest patch for libgomp and mic plugin. > make check-target-libgomp using intelmic emul passed. > Also I used a testcase from the attachment. This applies cleanly. > Latest ptx part is here, I guess: > https://gcc.gnu.org

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Thu, 26 Mar 2015 13:09:19 +0100 Jakub Jelinek wrote: > On Mon, Mar 23, 2015 at 10:44:39PM +0300, Ilya Verbin wrote: > > If it is too late for such global changes (rework initialization in > > libgomp, change mic and ptx plugins), then here is a small > > workaround patch to fix offloading from

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Thu, Mar 26, 2015 at 13:09:19 +0100, Jakub Jelinek wrote: > On Mon, Mar 23, 2015 at 10:44:39PM +0300, Ilya Verbin wrote: > > If it is too late for such global changes (rework initialization in libgomp, > > change mic and ptx plugins), then here is a small workaround patch to fix > > offloading f

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, Mar 23, 2015 at 10:44:39PM +0300, Ilya Verbin wrote: > If it is too late for such global changes (rework initialization in libgomp, > change mic and ptx plugins), then here is a small workaround patch to fix > offloading from libraries. Likely, it will not affect OpenACC programs with > o

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Mon, Mar 09, 2015 at 14:45:55 +, Julian Brown wrote: > On Fri, 6 Mar 2015 17:01:13 +0300 > Ilya Verbin wrote: > > > On Thu, Feb 26, 2015 at 20:25:11 +0300, Ilya Verbin wrote: > > > On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > > > > Julian Brown wrote: > > > > > This

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Fri, 6 Mar 2015 17:01:13 +0300 Ilya Verbin wrote: > On Thu, Feb 26, 2015 at 20:25:11 +0300, Ilya Verbin wrote: > > On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > > > Julian Brown wrote: > > > > This is a version of the previously-posted patch to rework > > > > initialisati

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Thu, Feb 26, 2015 at 20:25:11 +0300, Ilya Verbin wrote: > On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > > Julian Brown wrote: > > > This is a version of the previously-posted patch to rework > > > initialisation and support the proposed load/unload hooks, merged to > > > go

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

Hi, On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > Julian Brown wrote: > > This is a version of the previously-posted patch to rework > > initialisation and support the proposed load/unload hooks, merged to > > gomp4 branch and tested alongside the two patches (from Currently

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, Feb 25, 2015 at 10:36:08 +0100, Thomas Schwinge wrote: > > Julian Brown wrote: > > OK for gomp4 branch? I could commit Ilya's patch there too if so. > > I'll leave the decision to Jakub, but, what about trunk? As Ilya > indicated in >

Re: libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On Wed, 25 Feb 2015 10:36:08 +0100 Thomas Schwinge wrote: > Hi! > > On Tue, 24 Feb 2015 11:29:51 +, Julian Brown > wrote: > > Test results look OK, barring a suspected harness issue (lib-83 > > failing with a timeout for nvptx > > However, I'm seeing a class of testsuite regressions: all v

libgomp nvptx plugin: rework initialisation and support the proposed load/unload hooks (was: Merge current set of OpenACC changes from gomp-4_0-branch)

Hi! On Tue, 24 Feb 2015 11:29:51 +, Julian Brown wrote: > On Wed, 4 Feb 2015 15:05:45 + > Julian Brown wrote: > > > The major changes are: [...] Thanks for looking into this! > This is a version of the previously-posted patch to rework > initialisation and support the proposed load/u

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi, On Wed, 4 Feb 2015 15:05:45 + Julian Brown wrote: > The major changes are: > > * The removal of the OpenACC-specific plugin hooks open_device, > close_device, set_device_num and get_device_num. The functionality > has been moved into the init/fini hooks (for the first two) or moved

Fix number of arguments parameter in Ada DEF_FUNCTION_TYPE_* (was: Merge current set of OpenACC changes from gomp-4_0-branch)

Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. [...] > gcc/ada/ > * gcc-interface/utils.c (DEF_FUNCTION_TYPE_VAR_8) > (DEF_FUNCTION_TYPE_VAR_12): New macros

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Wed, Feb 04, 2015 at 15:05:45 +, Julian Brown wrote: > This (WIP) patch is based on top of a version of your patch that I > merged to our internal branch: that's still the easiest way for me to > test the PTX backend (with unloading support) at present, and it passes > libgomp testing that w

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. This whole file is scheduled to go away: the routines are to be replaced by builtins which are expanded in the nvptx backend, bu

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Tue, 3 Feb 2015 23:01:04 +0300 Ilya Verbin wrote: > On 03 Feb 13:00, Julian Brown wrote: > > On Tue, 3 Feb 2015 14:28:44 +0300 > > Ilya Verbin wrote: > > > On 27 Jan 14:07, Julian Brown wrote: > > > > On Mon, 26 Jan 2015 17:34:26 +0300 > > > > Ilya Verbin wrote: > > > > > Here is my current

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On 03 Feb 13:00, Julian Brown wrote: > On Tue, 3 Feb 2015 14:28:44 +0300 > Ilya Verbin wrote: > > On 27 Jan 14:07, Julian Brown wrote: > > > On Mon, 26 Jan 2015 17:34:26 +0300 > > > Ilya Verbin wrote: > > > > Here is my current patch, it works for OpenMP->MIC, but obviously > > > > will not work

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Tue, 3 Feb 2015 14:28:44 +0300 Ilya Verbin wrote: > Hi Julian! > > On 27 Jan 14:07, Julian Brown wrote: > > On Mon, 26 Jan 2015 17:34:26 +0300 > > Ilya Verbin wrote: > > > Here is my current patch, it works for OpenMP->MIC, but obviously > > > will not work for PTX, since it requires symmetr

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi Julian! On 27 Jan 14:07, Julian Brown wrote: > On Mon, 26 Jan 2015 17:34:26 +0300 > Ilya Verbin wrote: > > Here is my current patch, it works for OpenMP->MIC, but obviously > > will not work for PTX, since it requires symmetrical changes in the > > plugin. Could you please take a look, whethe

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Thomas, Any plans to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64635 soon? On x86_64 darwin, the OpenACC merge resulted a huge number of failures in the libgomp test suite… === libgomp Summary === # of expected passes 10628 # of unexpected failures 724 # of unsupported tests 562 whic

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Mon, 26 Jan 2015 17:34:26 +0300 Ilya Verbin wrote: > Here is my current patch, it works for OpenMP->MIC, but obviously > will not work for PTX, since it requires symmetrical changes in the > plugin. Could you please take a look, whether it is possible to > support this new interface in PTX pl

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Mon, 26 Jan 2015 14:44:19 +0100 Thomas Schwinge wrote: > > On 17 Jan 02:16, Ilya Verbin wrote: > > > Unfortunately, it broke offloading from shared libraries (I mean > > > common libs with NEEDED entries, not dlopened). > > Sorry for that! > > > > Such things are not covered by the > > > tes

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On 26 Jan 14:44, Thomas Schwinge wrote: > On 17 Jan 02:16, Ilya Verbin wrote: > > Such things are not covered by the > > testsuite, that's why you missed this issue. Here is a simple testcase: > >

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi! Sorry for the late answer -- I've been on sick leave, and just now returning to work. Julian, would you please have a look at the following issues? > > > In r219682, I have committed to trunk our current set of OpenACC changes, > > > which we had prepared on gomp-4_0-branch. Thanks to every

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Fri, Jan 23, 2015 at 08:20:53PM +0300, Ilya Verbin wrote: > On 17 Jan 02:16, Ilya Verbin wrote: > > Hi! > > > > Unfortunately, it broke offloading from shared libraries (I mean common libs > > with NEEDED entries, not dlopened). Such things are not covered by the > > testsuite, that's why you

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On 17 Jan 02:16, Ilya Verbin wrote: > Hi! > > Unfortunately, it broke offloading from shared libraries (I mean common libs > with NEEDED entries, not dlopened). Such things are not covered by the > testsuite, that's why you missed this issue. Here is a simple testcase: > ... > So, you don't ass

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

Confirmed that this patch eliminates [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin and thus exposes [Bug libgomp/64635] New: darwin produces libgomp-plugin-host_nonshm.1.dylib but tries to load libgomp-plugin-host_nonshm.so.1 The additional hack (which should be fi

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On 16 Jan 19:23, Jack Howarth wrote: > As I read https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625#c3, the > requirement for __OFFLOAD_TABLE__ was not longer present and the > residual usages of it just had to be removed. The weak symbol on > darwin is fragile and seems to trip up on the existing

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

As I read https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625#c3, the requirement for __OFFLOAD_TABLE__ was not longer present and the residual usages of it just had to be removed. The weak symbol on darwin is fragile and seems to trip up on the existing code which produces undefined symbols for __

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On 16 Jan 18:22, Jack Howarth wrote: > On 86_64 Fedora 15, current gcc trunk only produces… > > nm libgcc_s.so.1 | grep OFF > 00215478 d _GLOBAL_OFFSET_TABLE_ > > and not __OFFLOAD_TABLE__, The libgcc_s.so.1 built on > x86_64-apple-darwin14 doesn't even contain the _GLOBAL_OFFSET_TABLE_

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On 86_64 Fedora 15, current gcc trunk only produces… nm libgcc_s.so.1 | grep OFF 00215478 d _GLOBAL_OFFSET_TABLE_ and not __OFFLOAD_TABLE__, The libgcc_s.so.1 built on x86_64-apple-darwin14 doesn't even contain the _GLOBAL_OFFSET_TABLE_ symbol. On Fri, Jan 16, 2015 at 5:40 PM, Ilya Ver

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi! On 15 Jan 21:20, Thomas Schwinge wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! Unfortunately, it broke offloading from shared libraries (I mean common libs with NE

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

On 16 Jan 21:34, Thomas Schwinge wrote: > On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > Here is a patch to remove the __OFFLOAD_SYMBOL__ variable/formal > parameter, as discussed in . > > But -- I now wonder whether that's actually the issue that has been > reported i

Re: Merge current set of OpenACC changes from gomp-4_0-branch

FAIL: c-c++-common/goacc/acc_on_device-2-off.c -std=c++98 scan-rtl-dump-times expand "(call [^n]*"acc_on_device" 1 FAIL: c-c++-common/goacc/acc_on_device-2-off.c -std=c++11 scan-rtl-dump-times expand "(call [^n]*"acc_on_device" 1 FAIL: c-c++-common/goacc/acc_on_device-

[PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

Hi! On Thu, 15 Jan 2015 21:20:07 +0100, I wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, Here is a patch to remove the __OFFLOAD_SYMBOL__ variable/formal parameter, as discussed in . But -- I now wonder whether that's actually the

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi Gerald! On Fri, 16 Jan 2015 13:32:10 +0100 (CET), Gerald Pfeifer wrote: > On Thursday 2015-01-15 21:20, Thomas Schwinge wrote: > > In r219682, I have committed to trunk our current set of OpenACC changes, > > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > > been contr

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Fri, 2015-01-16 at 15:39 +0100, Jakub Jelinek wrote: > On Thu, Jan 15, 2015 at 09:20:07PM +0100, Thomas Schwinge wrote: > > * builtin-types.def (BT_FN_VOID_INT_INT_VAR) > > (BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR) > > > > (BT_FN_VOID_INT_OMPFN_PTR_SI

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Thu, Jan 15, 2015 at 09:20:07PM +0100, Thomas Schwinge wrote: > * builtin-types.def (BT_FN_VOID_INT_INT_VAR) > (BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR) > (BT_FN_VOID_INT_OMPFN_PTR_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR): > New function types. This broke bootst

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Once I work around the previous failure, I quickly get another one on FreeBSD 8.4/amd64: /scratch/tmp/gerald/gcc-HEAD/libgomp/target.c:67:12: error: \xe2\x80\x98num_devices\xe2\x80\x99 defined but not used [-Werror=unused-variable] static int num_devices; ^ This one did not require

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi Thomas, On Thursday 2015-01-15 21:20, Thomas Schwinge wrote: > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! this breaks bootstrap on FreeBSD 8/amd64 from what I can tell:

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Fri, Jan 16, 2015 at 11:46:35AM +0100, Uros Bizjak wrote: > On Fri, Jan 16, 2015 at 11:39 AM, Uros Bizjak wrote: > > Hello! > > > >> In r219682, I have committed to trunk our current set of OpenACC changes, > >> which we had prepared on gomp-4_0-branch. Thanks to everyone who has > >> been con

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On Fri, Jan 16, 2015 at 11:39 AM, Uros Bizjak wrote: > Hello! > >> In r219682, I have committed to trunk our current set of OpenACC changes, >> which we had prepared on gomp-4_0-branch. Thanks to everyone who has >> been contributing! > > This patch breaks bootstrap on alpha-linux-gnu: > "target

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hello! > In r219682, I have committed to trunk our current set of OpenACC changes, > which we had prepared on gomp-4_0-branch. Thanks to everyone who has > been contributing! This patch breaks bootstrap on alpha-linux-gnu: /space/homedirs/uros/gcc-build/./gcc/xgcc -B/space/homedirs/uros/gcc-bui

Re: Merge current set of OpenACC changes from gomp-4_0-branch

Hi Thomas, thanks to you and all others involved for the OpenACC merge. Attached is a patch which converts for Fortran '%s' into %qs, as mentioned to before. (It wasn't possible when the original patch was reviewed as the common diagnostic patches came later.) Committed as Rev. 219694. On

Re: Merge current set of OpenACC changes from gomp-4_0-branch

On 01/15/15 13:20, Thomas Schwinge wrote: Hi! In r219682, I have committed to trunk our current set of OpenACC changes, which we had prepared on gomp-4_0-branch. Thanks to everyone who has been contributing! Note that this is an experimental feature, incomplete, and subject to change in future