Re: Make ifcvt clean up dead comparisons

2019-07-12 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jul 12, 2019 at 12:28 PM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Fri, Jul 12, 2019 at 10:00 AM Richard Sandiford >> > wrote: >> >> >> >> This change is needed to avoid a regression in gcc.dg/ifcvt-3.c >> >> for a later patch. Without it,

Re: Make ifcvt clean up dead comparisons

2019-07-12 Thread Richard Biener
On Fri, Jul 12, 2019 at 12:28 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Fri, Jul 12, 2019 at 10:00 AM Richard Sandiford > > wrote: > >> > >> This change is needed to avoid a regression in gcc.dg/ifcvt-3.c > >> for a later patch. Without it, we enter CSE with a dead compariso

Re: Make ifcvt clean up dead comparisons

2019-07-12 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jul 12, 2019 at 10:00 AM Richard Sandiford > wrote: >> >> This change is needed to avoid a regression in gcc.dg/ifcvt-3.c >> for a later patch. Without it, we enter CSE with a dead comparison left >> by if-conversion and then eliminate the second (live) compariso

Re: Make ifcvt clean up dead comparisons

2019-07-12 Thread Richard Biener
On Fri, Jul 12, 2019 at 10:00 AM Richard Sandiford wrote: > > This change is needed to avoid a regression in gcc.dg/ifcvt-3.c > for a later patch. Without it, we enter CSE with a dead comparison left > by if-conversion and then eliminate the second (live) comparison in > favour of the dead one.

Make ifcvt clean up dead comparisons

2019-07-12 Thread Richard Sandiford
This change is needed to avoid a regression in gcc.dg/ifcvt-3.c for a later patch. Without it, we enter CSE with a dead comparison left by if-conversion and then eliminate the second (live) comparison in favour of the dead one. That's functionally correct in itself, but it meant that we'd combine