Re: LoongArch: add model attribute

2022-08-30 Thread Richard Sandiford via Gcc-patches
Xi Ruoyao via Gcc-patches writes: > Another attempt to make kernel module happy. > > One remaining issue: the patch cannot diagnostic some insane thing like > > int x __attribute__((model("normal"))); > int x __attribute__((model("extreme"))); > > It seems incredibly difficult to diagnose

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Lulu Cheng
在 2022/8/25 下午7:41, Xi Ruoyao 写道: On Thu, 2022-08-25 at 17:12 +0800, Xi Ruoyao via Gcc-patches wrote: On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: I think this should add a sentence: "Currently, the identifier name can only be one of small or extreme." I'll add this line and

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 17:12 +0800, Xi Ruoyao via Gcc-patches wrote: > On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: > > I think this should add a sentence: > > > > > > "Currently, the identifier name can only be one of small or > > extreme." > > I'll add this line and spend some time

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Xi Ruoyao via Gcc-patches
On Thu, 2022-08-25 at 16:53 +0800, Lulu Cheng wrote: > I think this should add a sentence: > > > "Currently, the identifier name can only be one of small or extreme." I'll add this line and spend some time trying to see how to reliably reproduce the ICE mentioned in 1/2 before committing. >

Re: [PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-25 Thread Lulu Cheng
在 2022/8/24 下午10:12, Xi Ruoyao 写道: On Wed, 2022-08-24 at 22:08 +0800, Xi Ruoyao wrote: v1 -> v2:  * Avoid introduce of SYMBOL_PCREL32, use SYMBOL_PCREL for 32-bit PC    relative.  * Rebase onto a bug fix ([1/2] in the series) to avoid merge conflict.  * Fix missed ChangeLog entries. Rese

[PATCH v2 2/2 resend] LoongArch: add model attribute

2022-08-24 Thread Xi Ruoyao via Gcc-patches
On Wed, 2022-08-24 at 22:08 +0800, Xi Ruoyao wrote: > v1 -> v2: > >  * Avoid introduce of SYMBOL_PCREL32, use SYMBOL_PCREL for 32-bit PC >    relative. >  * Rebase onto a bug fix ([1/2] in the series) to avoid merge conflict. >  * Fix missed ChangeLog entries. Resend because my mail client has do

[PATCH v2 2/2] LoongArch: add model attribute

2022-08-24 Thread Xi Ruoyao via Gcc-patches
v1 -> v2: * Avoid introduce of SYMBOL_PCREL32, use SYMBOL_PCREL for 32-bit PC relative. * Rebase onto a bug fix ([1/2] in the series) to avoid merge conflict. * Fix missed ChangeLog entries. -- >8 -- A linker script and/or a section attribute may locate some object specially, so we need to

Re: LoongArch: add model attribute

2022-08-23 Thread Lulu Cheng
在 2022/8/23 下午10:51, Xi Ruoyao 写道: diff --git a/gcc/config/loongarch/loongarch-protos.h b/gcc/config/loongarch/loongarch-protos.h index cadaad7519c..4e925aa3876 100644 --- a/gcc/config/loongarch/loongarch-protos.h +++ b/gcc/config/loongarch/loongarch-protos.h @@ -30,6 +30,12 @@ along with GCC;

LoongArch: add model attribute

2022-08-23 Thread Xi Ruoyao via Gcc-patches
Another attempt to make kernel module happy. One remaining issue: the patch cannot diagnostic some insane thing like int x __attribute__((model("normal"))); int x __attribute__((model("extreme"))); It seems incredibly difficult to diagnose such thing: I can't figure out any solution w/o