Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-06-03 Thread Maciej Rozycki
On Mon, 3 Jun 2019, Ian Lance Taylor wrote: > > I have results as at r270765, taken with QEMU run in the user emulation > > mode (I have patches outstanding for configury/Makefiles to correctly > > support libgo and other library testing with a build sysroot in such a > > setup, pending the compl

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-06-03 Thread Andreas Schwab
On Jun 03 2019, Maciej Rozycki wrote: > These are significantly worse, but I suspect the use of the user emulation > mode of QEMU may have contributed here. I think all your failures are due to bugs/limitations in the qemu emulation. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-06-03 Thread Ian Lance Taylor
On Mon, Jun 3, 2019 at 7:12 AM Maciej Rozycki wrote: > > On Thu, 30 May 2019, Jim Wilson wrote: > > > > Here are the test results: > > > http://gcc.gnu.org/ml/gcc-testresults/2019-05/msg02903.html > > > > I tried running RISC-V go checks on my system. I see 7 unexpected > > failures for gcc check

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-06-03 Thread Maciej Rozycki
On Thu, 30 May 2019, Jim Wilson wrote: > > Here are the test results: > > http://gcc.gnu.org/ml/gcc-testresults/2019-05/msg02903.html > > I tried running RISC-V go checks on my system. I see 7 unexpected > failures for gcc check-go, 6 unexpected failures for check-gotools, > and 1 unexpected fai

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Thu, May 30, 2019 at 11:11 AM Andreas Schwab wrote: > Here are the test results: > http://gcc.gnu.org/ml/gcc-testresults/2019-05/msg02903.html I tried running RISC-V go checks on my system. I see 7 unexpected failures for gcc check-go, 6 unexpected failures for check-gotools, and 1 unexpected

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Wed, May 22, 2019 at 6:36 PM Cherry Zhang wrote: > Jim, thank you for the fix! The patch looks good to me. Maybe we should also > apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8? Sorry about the delay, I caught a virus last week and am behind on everything. For 64-bit RISC-V thos

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Jim Wilson
On Wed, May 22, 2019 at 6:41 PM Ian Lance Taylor wrote: > Jim, you can go ahead and commit that patch with a ChangeLog entry. > (The files in go/gcc but not in go/gcc/gofrontend) are under normal > GCC rules.) Thanks. OK. Committed. I did an x86_64-linux go build and check to make sure I didn'

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-30 Thread Andreas Schwab
On Mai 21 2019, Jim Wilson wrote: > On Sun, May 19, 2019 at 5:22 AM Andreas Schwab wrote: >> ../../../libgo/go/runtime/mbitmap.go: In function >> ‘runtime.setMarked.runtime.markBits’: >> ../../../libgo/go/runtime/mbitmap.go:291:9: internal compiler error: >> Segmentation fault >> 291 | atom

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-22 Thread Ian Lance Taylor
On Wed, May 22, 2019 at 9:36 PM Cherry Zhang wrote: > > Jim, thank you for the fix! The patch looks good to me. Maybe we should also > apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8? > > Thanks, > Cherry > > > > On Tue, May 21, 2019 at 11:25 PM Jim Wilson wrote: >> >> On Sun, May 19

Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-22 Thread Cherry Zhang via gcc-patches
Jim, thank you for the fix! The patch looks good to me. Maybe we should also apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8? Thanks, Cherry On Tue, May 21, 2019 at 11:25 PM Jim Wilson wrote: > On Sun, May 19, 2019 at 5:22 AM Andreas Schwab > wrote: > > ../../../libgo/go/runtime/

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-21 Thread Jim Wilson
On Sun, May 19, 2019 at 5:22 AM Andreas Schwab wrote: > ../../../libgo/go/runtime/mbitmap.go: In function > ‘runtime.setMarked.runtime.markBits’: > ../../../libgo/go/runtime/mbitmap.go:291:9: internal compiler error: > Segmentation fault > 291 | atomic.Or8(m.bytep, m.mask) > | ^

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-19 Thread Andreas Schwab
I'm getting this crash on riscv: /daten/riscv64/gcc/gcc-20190518/Build/./gcc/gccgo -B/daten/riscv64/gcc/gcc-20190518/Build/./gcc/ -B/usr/riscv64-suse-linux/bin/ -B/usr/riscv64-suse-linux/lib/ -isystem /usr/riscv64-suse-linux/include -isystem /usr/riscv64-suse-linux/sys-include -O2 -g -I . -c -

Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang intrinsifies the runtime/internal/atomic functions. Currently the runtime/internal/atomic functions are implemented in C using C compiler intrinsics. This patch lets the Go frontend recognize these functions and turn them into intrinsics directly. Bo