Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-09 Thread Ian Lance Taylor
On Fri, Sep 9, 2016 at 6:52 AM, Andreas Schwab wrote: > > You should use alignof(ucontext_t) instead of hardcoding 16. Fair enough. Done like so. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu, committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-09 Thread Andreas Schwab
On Sep 09 2016, Ian Lance Taylor wrote: > Index: libgo/runtime/proc.c > === > --- libgo/runtime/proc.c (revision 239872) > +++ libgo/runtime/proc.c (working copy) > @@ -156,6 +156,20 @@ fixcontext(ucontext_t *c) > > #end

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-09 Thread Ian Lance Taylor
On Fri, Sep 2, 2016 at 9:27 AM, Andreas Schwab wrote: > On Sep 02 2016, Ian Lance Taylor wrote: > >> On Fri, Sep 2, 2016 at 9:14 AM, Andreas Schwab wrote: >>> >>> That breaks libgo on ia64. The problem is that _ucontext_t isn't >>> properly aligned. >> >> Interesting. Thanks for looking into i

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-02 Thread Andreas Schwab
On Sep 02 2016, Andreas Schwab wrote: > On Sep 02 2016, Ian Lance Taylor wrote: > >> On Fri, Sep 2, 2016 at 9:14 AM, Andreas Schwab wrote: >>> >>> That breaks libgo on ia64. The problem is that _ucontext_t isn't >>> properly aligned. >> >> Interesting. Thanks for looking into it. What is the

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-02 Thread Andreas Schwab
On Sep 02 2016, Ian Lance Taylor wrote: > On Fri, Sep 2, 2016 at 9:14 AM, Andreas Schwab wrote: >> >> That breaks libgo on ia64. The problem is that _ucontext_t isn't >> properly aligned. > > Interesting. Thanks for looking into it. What is the required > alignment? This code should be align

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-02 Thread Ian Lance Taylor
On Fri, Sep 2, 2016 at 9:14 AM, Andreas Schwab wrote: > > That breaks libgo on ia64. The problem is that _ucontext_t isn't > properly aligned. Interesting. Thanks for looking into it. What is the required alignment? This code should be aligning it to a pointer boundary. Ian

Re: Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-09-02 Thread Andreas Schwab
That breaks libgo on ia64. The problem is that _ucontext_t isn't properly aligned. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Fwd: libgo patch committed: Use -fgo-c-header to share between Go and C

2016-08-30 Thread Ian Lance Taylor
Resending without the attachment as it was blocked as spam. The actual change be seen in Subversion or at https://groups.google.com/forum/?pli=1#!topic/gofrontend-dev/fT2-PlvVZ9o . Ian -- Forwarded message -- From: Ian Lance Taylor Date: Tue, Aug 30, 2016 at 2:07 PM Subject: li