Re: [C++ patch] Re: Free more of CFG in release_function_body

2020-11-30 Thread Jason Merrill via Gcc-patches
On 11/27/20 8:26 AM, Jan Hubicka wrote: On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: On Tue, 24 Nov 2020, Jan Hubicka wrote: Hi, at the end of processing function body we loop over basic blocks and free all edges while we do not free the rest. I think this is leftover from time eges

Re: [C++ patch] Re: Free more of CFG in release_function_body

2020-11-29 Thread Jeff Law via Gcc-patches
On 11/27/20 6:26 AM, Jan Hubicka wrote: >>> On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: > On Tue, 24 Nov 2020, Jan Hubicka wrote: > >> Hi, >> at the end of processing function body we loop over basic blocks and >> free all edges while we do not free the rest. I think

[C++ patch] Re: Free more of CFG in release_function_body

2020-11-27 Thread Jan Hubicka
> > On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: > > > > > > > On Tue, 24 Nov 2020, Jan Hubicka wrote: > > > > > > > > > Hi, > > > > > at the end of processing function body we loop over basic blocks and > > > > > free all edges while we do not free the rest. I think this is > > > > > left

Re: Free more of CFG in release_function_body

2020-11-25 Thread Richard Biener
On Wed, 25 Nov 2020, Jan Hubicka wrote: > > On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: > > > > > > > On Tue, 24 Nov 2020, Jan Hubicka wrote: > > > > > > > > > Hi, > > > > > at the end of processing function body we loop over basic blocks and > > > > > free all edges while we do not free t

Re: Free more of CFG in release_function_body

2020-11-25 Thread Jan Hubicka
> On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: > > > > > On Tue, 24 Nov 2020, Jan Hubicka wrote: > > > > > > > Hi, > > > > at the end of processing function body we loop over basic blocks and > > > > free all edges while we do not free the rest. I think this is leftover > > > > from time eg

Re: Free more of CFG in release_function_body

2020-11-25 Thread Richard Biener via Gcc-patches
On Wed, Nov 25, 2020 at 3:11 PM Jan Hubicka wrote: > > > On Tue, 24 Nov 2020, Jan Hubicka wrote: > > > > > Hi, > > > at the end of processing function body we loop over basic blocks and > > > free all edges while we do not free the rest. I think this is leftover > > > from time eges was not garba

Re: Free more of CFG in release_function_body

2020-11-25 Thread Jan Hubicka
> On Tue, 24 Nov 2020, Jan Hubicka wrote: > > > Hi, > > at the end of processing function body we loop over basic blocks and > > free all edges while we do not free the rest. I think this is leftover > > from time eges was not garbage collected and we was not using ggc_free. > > It makes more sen

Re: Free more of CFG in release_function_body

2020-11-24 Thread Richard Biener
On Tue, 24 Nov 2020, Jan Hubicka wrote: > Hi, > at the end of processing function body we loop over basic blocks and > free all edges while we do not free the rest. I think this is leftover > from time eges was not garbage collected and we was not using ggc_free. > It makes more sense to free all

Free more of CFG in release_function_body

2020-11-24 Thread Jan Hubicka
Hi, at the end of processing function body we loop over basic blocks and free all edges while we do not free the rest. I think this is leftover from time eges was not garbage collected and we was not using ggc_free. It makes more sense to free all associated structures (which is importnat for WPA