Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-12 Thread Prathamesh Kulkarni
On 13 January 2015 at 00:01, Mike Stump wrote: > On Jan 11, 2015, at 2:33 PM, Prathamesh Kulkarni > wrote: >> oops, sorry about this. We will build further flattening patches with >> --enable-languages=all,go,jit,ada. >> Shall that cover all the front-ends ? > > No objc++ is non-default: Thanks!

Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-12 Thread Mike Stump
On Jan 11, 2015, at 2:33 PM, Prathamesh Kulkarni wrote: > oops, sorry about this. We will build further flattening patches with > --enable-languages=all,go,jit,ada. > Shall that cover all the front-ends ? No objc++ is non-default: $ grep build_by_default */config-lang.in go/config-lang.in:build

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-12 Thread Prathamesh Kulkarni
On 12 January 2015 at 16:24, Andreas Schwab wrote: > I'm getting this testsuite regression: > > FAIL: gcc.dg/plugin/ggcplug.c compilation Fixed with r219458. Thanks, Prathamesh > > In file included from > /usr/local/gcc/gcc-20150112/gcc/testsuite/../../gcc/tree.h:23:0, > from >

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-12 Thread Andreas Schwab
I'm getting this testsuite regression: FAIL: gcc.dg/plugin/ggcplug.c compilation In file included from /usr/local/gcc/gcc-20150112/gcc/testsuite/../../gcc/tree.h:23:0, from /usr/local/gcc/gcc-20150112/gcc/testsuite/gcc.dg/plugin/ggcplug.c:8: /usr/local/gcc/gcc-20150112/gcc/test

[BUILDROBOT] tilepro-linux/tilegx-linux fallout from flattening (was: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-11 Thread Jan-Benedict Glaw
On Sat, 2015-01-10 01:50:42 +0530, Prathamesh Kulkarni wrote: > On 9 January 2015 at 16:21, Richard Biener wrote: > > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison > > wrote: > > > This patch flattens tree.h and tree-core.h. This is a revised > > > patch that does not include tree-core.h a

Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-11 Thread Prathamesh Kulkarni
On 10 January 2015 at 03:17, David Malcolm wrote: > On Sat, 2015-01-10 at 01:50 +0530, Prathamesh Kulkarni wrote: >> On 9 January 2015 at 16:21, Richard Biener >> wrote: >> > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison >> > wrote: >> >> This patch flattens tree.h and tree-core.h. This is

[PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

2015-01-09 Thread David Malcolm
On Sat, 2015-01-10 at 01:50 +0530, Prathamesh Kulkarni wrote: > On 9 January 2015 at 16:21, Richard Biener wrote: > > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison > > wrote: > >> This patch flattens tree.h and tree-core.h. This is a revised patch that > >> does not include tree-core.h as a r

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Prathamesh Kulkarni
On 10 January 2015 at 02:58, Jakub Jelinek wrote: > On Sat, Jan 10, 2015 at 01:50:42AM +0530, Prathamesh Kulkarni wrote: >> >> I bootstrapped on x86 with all languages. I also bootstrapped on all >> >> targets >> >> listed in contrib/config-list.mk with c and c++ enabled. >> >> >> >> Is this okay

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Jakub Jelinek
On Sat, Jan 10, 2015 at 01:50:42AM +0530, Prathamesh Kulkarni wrote: > >> I bootstrapped on x86 with all languages. I also bootstrapped on all > >> targets > >> listed in contrib/config-list.mk with c and c++ enabled. > >> > >> Is this okay for trunk? > > > > Ok. > Committed as r219402 on behalf o

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Prathamesh Kulkarni
On 9 January 2015 at 16:21, Richard Biener wrote: > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison > wrote: >> This patch flattens tree.h and tree-core.h. This is a revised patch that >> does not include tree-core.h as a result of flattening. >> >> Version 3 of the patch adds the header files

Re: [PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Richard Biener
On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison wrote: > This patch flattens tree.h and tree-core.h. This is a revised patch that > does not include tree-core.h as a result of flattening. > > Version 3 of the patch adds the header files removed from tree-core.h to > gcc-plugin.h in order to allo

[PATCH] Flatten tree.h and tree-core.h (Version 3)

2015-01-09 Thread Michael Collison
This patch flattens tree.h and tree-core.h. This is a revised patch that does not include tree-core.h as a result of flattening. Version 3 of the patch adds the header files removed from tree-core.h to gcc-plugin.h in order to allow ggc-common.c to compile. This is a recent issue seen on trunk

[PING] Flatten tree.h and tree-core.h (Version 2)

2015-01-07 Thread Michael Collison
Ping. Any update on this patch? https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01848.html -- Michael Collison Linaro Toolchain Working Group michael.colli...@linaro.org

Flatten tree.h and tree-core.h (Version 2)

2014-12-24 Thread Michael Collison
This patch flattens tree.h and tree-core.h. This is a revised patch that does not include tree-core.h as a result of flattening. I removed the includes in tree.h and tree-core.h except for the include of tree-core.h in tree.h. I modified genattrtab.c, genautomata.c, genemit.c, gengtype.c, ge

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
Andrew, Yes it appears those are the three offenders. I like the approach of moving them to fold-const.c and exporting from fold-const.h. I will try that approach. On 12/19/2014 02:10 PM, Andrew MacLeod wrote: On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 03:46 PM, Michael Collison wrote: The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-c

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Prathamesh Kulkarni
On 20 December 2014 at 02:16, Michael Collison wrote: > The reason I included tree-core.h in all the .c files was the requirement in > tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are > inline functions such as fold_build_pointer_plus_hwi_loc which reference > functions

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Michael Collison
The reason I included tree-core.h in all the .c files was the requirement in tree.h (now flattened to the .c files) for fold-const.h. In tree.h there are inline functions such as fold_build_pointer_plus_hwi_loc which reference functions in fold-const.h. The moment you include fold-const.h you r

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 01:12 PM, Richard Biener wrote: On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Archi

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On December 19, 2014 2:44:00 PM CET, Andrew MacLeod wrote: >On 12/19/2014 06:20 AM, Richard Biener wrote: >> On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison >> wrote: >>> This patch flattens tree.h and tree-core.h. This work is part of the >GCC >>> Re-Architecture effort being led by Andrew Ma

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 08:44 AM, Andrew MacLeod wrote: On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the inc

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Andrew MacLeod
On 12/19/2014 06:20 AM, Richard Biener wrote: On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the includes in tree.h and tree-core.h except for the i

Re: Flatten tree.h and tree-core.h

2014-12-19 Thread Richard Biener
On Fri, Dec 19, 2014 at 1:37 AM, Michael Collison wrote: > This patch flattens tree.h and tree-core.h. This work is part of the GCC > Re-Architecture effort being led by Andrew MacLeod. > > I removed the includes in tree.h and tree-core.h except for the include of > tree-core.h in tree.h. > > I mo

Flatten tree.h and tree-core.h

2014-12-18 Thread Michael Collison
This patch flattens tree.h and tree-core.h. This work is part of the GCC Re-Architecture effort being led by Andrew MacLeod. I removed the includes in tree.h and tree-core.h except for the include of tree-core.h in tree.h. I modified genattrtab.c, genautomata.c, genemit.c, gengtype.c, gengty