Re: [PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Jeff Law
On 10/16/14 06:40, Markus Trippelsdorf wrote: (I've taken Alan's patch and added two new testcases.) This patch cures the linux kernel boot failure when compiled using trunk gcc. At its heart, the problem is caused by merge_decls merging from the old decl to the new decl, then copying back to t

Re: Fix pr61848, linux kernel miscompile

2014-10-16 Thread Jeff Law
On 10/15/14 22:51, Alan Modra wrote: Target independent tests are always best, but pulling together one that is specific to a target is usually still good enough. Especially if it's an x86 target given how often those are tested by the developer community as a whole. I think for #1 in your post

[PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Markus Trippelsdorf
(I've taken Alan's patch and added two new testcases.) This patch cures the linux kernel boot failure when compiled using trunk gcc. At its heart, the problem is caused by merge_decls merging from the old decl to the new decl, then copying back to the old decl and discarding the new. When Jan m

Re: Fix pr61848, linux kernel miscompile

2014-10-15 Thread Alan Modra
On Thu, Sep 18, 2014 at 10:02:25PM -0600, Jeff Law wrote: > On 09/16/14 00:03, Alan Modra wrote: > >gcc testsuite additions? I decline. It is too soon. If you had read > >my patch submission you'll see that at some stage gcc was supposed to > >warn on conflicting section attributes, but hasn't d

Re: Fix pr61848, linux kernel miscompile

2014-09-18 Thread Jeff Law
On 09/16/14 00:03, Alan Modra wrote: gcc testsuite additions? I decline. It is too soon. If you had read my patch submission you'll see that at some stage gcc was supposed to warn on conflicting section attributes, but hasn't done so for a very long time. There needs to be some agreement on w

Re: Fix pr61848, linux kernel miscompile

2014-09-17 Thread Alan Modra
On Tue, Sep 16, 2014 at 01:03:50PM +, Joseph S. Myers wrote: > The point of testsuite additions is to verify the visible changes in Understood. A long time ago I worked on mil-spec systems.. > > Come to think of it, what if I decline to make any testsuite > > additions? > > Then the patch

Re: Fix pr61848, linux kernel miscompile

2014-09-16 Thread Joseph S. Myers
On Tue, 16 Sep 2014, Alan Modra wrote: > gcc testsuite additions? I decline. It is too soon. If you had read > my patch submission you'll see that at some stage gcc was supposed to > warn on conflicting section attributes, but hasn't done so for a very > long time. There needs to be some agree

Re: Fix pr61848, linux kernel miscompile

2014-09-15 Thread Alan Modra
On Mon, Sep 15, 2014 at 08:36:58PM +, Joseph S. Myers wrote: > On Mon, 15 Sep 2014, Alan Modra wrote: > > > This patch cures the linux kernel boot failure when compiled using > > trunk gcc. (Andrew, apologies for hijacking your bugzilla, I started > > work on this before finding the bugzilla.

Re: Fix pr61848, linux kernel miscompile

2014-09-15 Thread Joseph S. Myers
On Mon, 15 Sep 2014, Alan Modra wrote: > This patch cures the linux kernel boot failure when compiled using > trunk gcc. (Andrew, apologies for hijacking your bugzilla, I started > work on this before finding the bugzilla..) Please include testcases in your patch for each case that you fix. --

Re: Fix pr61848, linux kernel miscompile

2014-09-14 Thread Andrew Pinski
On Sun, Sep 14, 2014 at 9:02 PM, Alan Modra wrote: > This patch cures the linux kernel boot failure when compiled using > trunk gcc. (Andrew, apologies for hijacking your bugzilla, I started > work on this before finding the bugzilla..) It is ok that you took over as it looks like you have a mor

Fix pr61848, linux kernel miscompile

2014-09-14 Thread Alan Modra
This patch cures the linux kernel boot failure when compiled using trunk gcc. (Andrew, apologies for hijacking your bugzilla, I started work on this before finding the bugzilla..) At its heart, the problem is caused by merge_decls merging from the old decl to the new decl, then copying back to th