Re: Fix debug/49825

2011-08-10 Thread H.J. Lu
On Sun, Jul 24, 2011 at 8:33 PM, Richard Henderson wrote: > With the last two fixes, the only remaining i686 regression > from Thursday is 1 fortran testcase, whose number I have > misplaced.  This highlights an accidental change I made while > moving code around between functions, and an assertio

Re: Fix debug/49825

2011-07-24 Thread Richard Henderson
With the last two fixes, the only remaining i686 regression from Thursday is 1 fortran testcase, whose number I have misplaced. This highlights an accidental change I made while moving code around between functions, and an assertion I added trying to see if we'd Done The Right Thing already. Th

Re: Fix debug/49825

2011-07-24 Thread Richard Henderson
As a follow-up, by inspection, args_size should be zeroed across edges for which we explicitly undo args_size, like EH. But we do the same thing for non-local gotos and computed gotos. I couldn't see any difference in the test results with this patch, and frankly I'm surprised about that. But,

Fix debug/49825

2011-07-24 Thread Richard Henderson
Tested on i686-linux. I'm not sure how I missed this with {,-m32} testing on x86_64. r~ PR debug/49825 * dwarf2cfi.c (cfi_row_equal_p): Don't compare args_size. diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index 3ff4c61..f715e07 100644 --- a/gcc/dwarf2cfi.c +++ b/gcc/dwarf2